Add support for c++20 likely/unlikely attributes#130
Merged
Conversation
Owner
|
Hi! sorry it took me so long, but this breaks the macos build |
Contributor
Author
|
Ah yes I see. Let me check and fix that. Edit: It seems the 'has attribute' check was not enough and it also requires a check for cpp20 version to work without errors |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately had to add another macro for it, since the attribute needs to be placed after the last bracket of the condition.
Maybe we can combine it into a single macro with some hackyness. Let me know what you'd prefer