Skip to content

New pages: row-rule, *-style, and *-width#44725

Merged
estelle merged 14 commits into
mainfrom
gaps5-rule-lines
Jul 18, 2026
Merged

New pages: row-rule, *-style, and *-width#44725
estelle merged 14 commits into
mainfrom
gaps5-rule-lines

Conversation

@estelle

@estelle estelle commented Jul 15, 2026

Copy link
Copy Markdown
Member

This PR includes three new pages:

  • row-rule
  • row-rule-style
  • row-rule-width

The CSS gaps module page is already live.
The row-rule-color is merged. (#44549)
This page is already linked to from those two pages and from row-rule-visibility-items

Part of openwebdocs/project#238

@estelle
estelle requested a review from a team as a code owner July 15, 2026 12:25
@estelle
estelle requested review from chrisdavidmills and removed request for a team July 15, 2026 12:25
@github-actions github-actions Bot added Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed labels Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Preview URLs (3 pages)

Flaws (15)

Found an unexpected or unresolvable flaw? Please report it here.

URL: /en-US/docs/Web/CSS/Reference/Properties/row-rule
Title: row-rule CSS property
Flaw count: 4

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/line-width which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/row-rule-style
Title: row-rule-style CSS property
Flaw count: 4

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule-style which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule-style which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/row-rule-width
Title: row-rule-width CSS property
Flaw count: 7

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/line-width which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/line-width which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule-width which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/line-width which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve
    • and 2 more flaws omitted

(comment last updated: 2026-07-18 20:53:44)

@estelle estelle mentioned this pull request Jul 15, 2026
61 tasks
@estelle
estelle marked this pull request as draft July 15, 2026 12:32
estelle and others added 7 commits July 15, 2026 15:17
Corrected minor grammatical errors and improved clarity in the explanations regarding the 'row-rule' property and its usage.
Corrected minor grammatical issues and improved clarity in the documentation for the 'row-rule-width' CSS property.
Corrected minor grammatical errors and formatting issues in the documentation for the `row-rule-style` CSS property.
@estelle
estelle marked this pull request as ready for review July 15, 2026 13:35
estelle added 2 commits July 16, 2026 11:00
Removed unused CSS variables from the example.

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @estelle. I've made a bunch of comments, but these are largely grammar fixes and suchlike. Nothing too serious.


- `<gap-rule>`
- : Specified as one, two, or three of the values listed below, in any order.
- `<'line-width'>`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of this inner DL is broken; the spacing needs some adjustment.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good on my end. Please double check for me though before approving.
line-width will stop being red after #44597

- `<gap-rule>`
- : Specified as one, two, or three of the values listed below, in any order.
- `<'line-width'>`
- : Is a {{cssxref("&lt;line-width&gt;")}}; a positive {{cssxref("&lt;length&gt;")}} or one of the three keywords, `thin`, `medium`, or `thick`. The default value is `medium. See {{cssxref("row-rule-width")}}.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- : Is a {{cssxref("&lt;line-width&gt;")}}; a positive {{cssxref("&lt;length&gt;")}} or one of the three keywords, `thin`, `medium`, or `thick`. The default value is `medium. See {{cssxref("row-rule-width")}}.
- : A {{cssxref("&lt;line-width&gt;")}}: a positive {{cssxref("&lt;length&gt;")}} or one of the three keywords, `thin`, `medium`, or `thick`. The default value is `medium. See {{cssxref("row-rule-width")}}.

- `<'line-width'>`
- : Is a {{cssxref("&lt;line-width&gt;")}}; a positive {{cssxref("&lt;length&gt;")}} or one of the three keywords, `thin`, `medium`, or `thick`. The default value is `medium. See {{cssxref("row-rule-width")}}.
- `<'line-style'>`
- : A {{cssxref("&lt;line-style&gt;")}}, either `none`, `hidden`, `dotted`, `dashed`, `solid`, `double`, `groove`, `ridge`, `inset`, or `outset`. The default value is `none`. {{cssxref("row-rule-style")}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- : A {{cssxref("&lt;line-style&gt;")}}, either `none`, `hidden`, `dotted`, `dashed`, `solid`, `double`, `groove`, `ridge`, `inset`, or `outset`. The default value is `none`. {{cssxref("row-rule-style")}}
- : A {{cssxref("&lt;line-style&gt;")}}: one of `none`, `hidden`, `dotted`, `dashed`, `solid`, `double`, `groove`, `ridge`, `inset`, or `outset`. The default value is `none`. See {{cssxref("row-rule-style")}}.

- `<'line-style'>`
- : A {{cssxref("&lt;line-style&gt;")}}, either `none`, `hidden`, `dotted`, `dashed`, `solid`, `double`, `groove`, `ridge`, `inset`, or `outset`. The default value is `none`. {{cssxref("row-rule-style")}}
- `<'color'>`
- : A {{cssxref("&lt;color&gt;")}} value representing the color of the line. The default value is `currentcolor`. {{cssxref("row-rule-color")}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- : A {{cssxref("&lt;color&gt;")}} value representing the color of the line. The default value is `currentcolor`. {{cssxref("row-rule-color")}}
- : A {{cssxref("&lt;color&gt;")}} value representing the color of the line. The default value is `currentcolor`. See {{cssxref("row-rule-color")}}.

- : A {{cssxref("repeat()")}} function, with an {{cssxref("&lt;integer&gt;")}} of `1` or more as the first argument and one or more `<gap-rule>` values as subsequent arguments. The `<integer>` specifies how many times the list of `<gap-rule>` values should be repeated.

- `<gap-auto-repeat-rule>`
- : A {{cssxref("repeat()")}} function, with `auto` as the first argument and one or more `<gap-rule>` values as subsequent arguments. The provided list of `<gap-rule>` values are repeated as many times as needed to fill in values for any row-rules that are not explicitly specified by other components of the property value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- : A {{cssxref("repeat()")}} function, with `auto` as the first argument and one or more `<gap-rule>` values as subsequent arguments. The provided list of `<gap-rule>` values are repeated as many times as needed to fill in values for any row-rules that are not explicitly specified by other components of the property value.
- : A {{cssxref("repeat()")}} function, with `auto` as the first argument and one or more `<gap-rule>` values as subsequent arguments. The provided list of `<gap-rule>` values is repeated as many times as needed to fill in values for any row-rules that are not explicitly specified by other components of the property value.

Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
flex-flow: column;
gap: 5px;
row-rule-style: dashed;
row-rule-width: 3px;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List the row-rule-width declaration last and separated by a line to highlight it, like you did with row-rule-style on that page?

Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @estelle. I've made a bunch of comments, but these are largely grammar fixes and suchlike. Nothing too serious.

Comment thread files/en-us/web/css/reference/properties/row-rule-style/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Comment thread files/en-us/web/css/reference/properties/row-rule/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
estelle and others added 2 commits July 17, 2026 11:36
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle
estelle requested a review from chrisdavidmills July 17, 2026 09:59

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle, a few more bits for you to consider, but I'm approving so that you can merge when you're done looking.

Comment thread files/en-us/web/css/reference/properties/row-rule-style/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-style/index.md Outdated
Comment thread files/en-us/web/css/reference/properties/row-rule-width/index.md Outdated
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle
estelle merged commit b13ef1f into main Jul 18, 2026
13 checks passed
@estelle
estelle deleted the gaps5-rule-lines branch July 18, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants