Skip to content

fix json parsing logic and warning message#833

Merged
AlonsoGuevara merged 3 commits into
mainfrom
fix/global-search-exception-msg
Aug 5, 2024
Merged

fix json parsing logic and warning message#833
AlonsoGuevara merged 3 commits into
mainfrom
fix/global-search-exception-msg

Conversation

@ha2trinh

@ha2trinh ha2trinh commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Description

Fix json parsing logic in global search and change json parsing exception message to warning to avoid confusion (since the exception would only affect a single batch of map response, but the system can still proceed with the remaining batches).

Related Issues

[Reference any related issues or tasks that this pull request addresses.]

Proposed Changes

  • Fix json parsing logic in parse_search_response
  • Change log.exception message to warning in _map_response_single_batch

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

Additional Notes

[Add any additional notes or context that may be helpful for the reviewer(s).]

@ha2trinh
ha2trinh requested a review from a team as a code owner August 5, 2024 21:27
Comment thread graphrag/query/structured_search/global_search/search.py Outdated
@AlonsoGuevara
AlonsoGuevara merged commit 4822465 into main Aug 5, 2024
@AlonsoGuevara
AlonsoGuevara deleted the fix/global-search-exception-msg branch August 5, 2024 22:31
Brandsma pushed a commit to ThalamusLabs/MMGraphRAG that referenced this pull request Nov 6, 2025
* fix json parsing logic and warning message

* amended warning message

---------

Co-authored-by: Alonso Guevara <alonsog@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants