Skip to content

Fix warning compiling core_stmt.cpp#1275

Merged
yitam merged 1 commit into
microsoft:PHP-8.1-devfrom
mlocati-forks:core_stmt-buffer_length
Jul 5, 2021
Merged

Fix warning compiling core_stmt.cpp#1275
yitam merged 1 commit into
microsoft:PHP-8.1-devfrom
mlocati-forks:core_stmt-buffer_length

Conversation

@mlocati

@mlocati mlocati commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

Let's fix this compilation warning:

source/sqlsrv/shared/core_stmt.cpp:3104:25: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
         buffer_length = NULL;
                         ^~~~

converting to non-pointer type 'long int' from NULL
@codecov

codecov Bot commented Jul 1, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1275 (8ab61eb) into PHP-8.1-dev (f00dc9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           PHP-8.1-dev    #1275   +/-   ##
============================================
  Coverage        83.27%   83.27%           
============================================
  Files               22       22           
  Lines             7780     7780           
============================================
  Hits              6479     6479           
  Misses            1301     1301           

@yitam

yitam commented Jul 5, 2021

Copy link
Copy Markdown
Contributor

Thanks @mlocati for the contribution.

@yitam
yitam merged commit bde9812 into microsoft:PHP-8.1-dev Jul 5, 2021
@mlocati
mlocati deleted the core_stmt-buffer_length branch July 5, 2021 16:33
@mlocati

mlocati commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

That was an easy one 😉

yitam pushed a commit that referenced this pull request Jul 5, 2021
converting to non-pointer type 'long int' from NULL
yitam added a commit that referenced this pull request Jul 5, 2021
converting to non-pointer type 'long int' from NULL

Co-authored-by: Michele Locati <michele@locati.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants