Debug toolbar contributed commands missing when toolbar is docked

[readyiman]

Issue Type: Bug

I works with Flutter and just updated VSCode to version 1.53 yesterday and this thing is happen:

1. Debug Console auto scroll stop scrolling to the end of line, it somehow always stop prematurely at start (just scroll a bit and then stop).
2. Flutter hot reload button was missing from Run buttons. The function ctrl+F5 still works though.

I think this is VSCode bug, and not Flutter/Dart bug. Because it happens after 1.53 update.

The Auto Scroll part is really annoying for me.

VS Code version: Code 1.53.0 (8490d3d, 2021-02-03T20:36:38.611Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item	Value
CPUs	Intel(R) Core(TM) i3-4170 CPU @ 3.70GHz (4 x 3691)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	7.90GB (1.08GB free)
Process Argv	--crash-reporter-id a704c221-6da9-4cb2-9758-c753a081462d
Screen Reader	no
VM	0%

Extensions (4)

Extension	Author (truncated)	Version
dart-code	Dar	3.19.1
flutter	Dar	3.19.0
githistory	don	0.6.14
todo-tree	Gru	0.0.196

(1 theme extensions excluded)

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30211402
vstry914:30250197
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30251590

[readyiman]

I found the problem.

1. Auto scroll on Debug Console not working because of Word Wrap. debug.console.wordWrap .Turning it off make it works.
2. Flutter hot reload button disappear if debug.toolBarLocation is docked. It's appear fine on floating.

[isidorn]

I can not reproduce this, can you share an exact reproducable steps for this?
@DanTup do you also see this? Did I break this again?

[DanTup]

@isidorn honestly, I haven't seen scrolling work right for quite a while. Each time I saw it I assumed the previous fix hadn't made stable yet (although in hindsight it does seem like a while now).

I just tried running Dart-Code's tests (TypeScript) though, and I'm not seeing any output in the Debug Console at all, which definitely doesn't seem right. The window on the left here is the extension code and the Debug Console should be filling up with Mocha output as the tests are running.

I'll let the run finish and see if anything shows up and post back. If nothing, I'll see if I can repro it and provide instructions for you to run the same thing.

[DanTup]

The screenshot above turned out to be because I was running in noDebug mode. I thought I used to get the test output even in that mode, but that doesn't seem to be the case today. Running without noDebug does show the output. It's probably unrelated to the scrolling issue being discussed here.

I did test with a Flutter app though, and was unable to reproduce either issue noted above (scrolling issues, or the hot reload button missing from the debug toolbar).

[isidorn]

@DanTup thanks for trying it out. Let's keep this open and see if more users face this
@readyiman can you reproduce with vscode insiders https://code.visualstudio.com/insiders/

[readyiman]

Its actually easy to reproduce for me.
First run a Flutter project.

To see that Debug Console not auto scrolling right you need:

1. Long and multiple text to show on it, like when your project has Google Map widget.
2. Make sure word wrap setting is on debug.console.wordWrap
3. Make sure your Debug Console window width is narrow.

To see Flutter hot reload missing:

1. Just change debug.toolBarLocation setting to docked.

Haven't try insider yet.

[isidorn]

@DanTup can you repro that the hot reload is missing when debug.toolBarLocation is docked?

I can not reproduce this with mock debug. As I nicely see contributed actions in the debug toolbar

[DanTup]

@isidorn actually, I can repro that:

I'm not really sure why. The definition is here:

https://github.com/Dart-Code/Dart-Code/blob/1fc34a7651dd3560cea71207e29669ca530792ef/package.json#L994-L999

There is a context on it that changes after the debug session starts (we wait to see whether the hot reload service is available in the debugger before enabling it). This was enabled by #69398 - is it possible that's not applying correctly when docked?

[DanTup]

The Inspector button is also disappeared - that also has a context on it (also toggled after the session starts, in a handleDebugSessionStart handler).