You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current stack frame icon is shown when the current stack is in focus, and this line contains the address of the top stack frame.
Current stack frame line background is set when the line contains the address of the top stack frame, no matter if the current stack is in focus.
Focused stack frame icon is shown and focused stack frame line background is set when this line contains the address of the focused stack frame, and it's not the top stack frame.
@xisui-MSFT this looks good to me, however i had a hard time getting into a situation to easily try this out with mock-debug.
Did you try it out with C++, does it works as expected.
I looked at the code and it looks good -> approved.
However since I could not try it out end to end I would prefer to merge this start of next week -> August. Please let me know if you would really like to ship this as part of the July release.
@isidorn I'm fine either shipping this in July or August. And yes I tested this using c++ extension.
@weinand Can you please add a few more levels of stack frames that has instructionPointerReference in disassembly view in the mock debugger? I can probably help as well if you prefer.
@xisui-MSFT In Mock Debug all stackframes have a instructionPointerReference if the corresponding source line contains the word disassembly. Just make sure to use the latest Mock-Debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #129574
Current stack frame icon is shown when the current stack is in focus, and this line contains the address of the top stack frame.
Current stack frame line background is set when the line contains the address of the top stack frame, no matter if the current stack is in focus.
Focused stack frame icon is shown and focused stack frame line background is set when this line contains the address of the focused stack frame, and it's not the top stack frame.