Skip to content

Fix folding ranges with inlay hints#130399

Merged
hediet merged 1 commit into
microsoft:mainfrom
Kingwl:fix_folding_with_inlayhints
Aug 11, 2021
Merged

Fix folding ranges with inlay hints#130399
hediet merged 1 commit into
microsoft:mainfrom
Kingwl:fix_folding_with_inlayhints

Conversation

@Kingwl

@Kingwl Kingwl commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

This PR fixes #129682

image

@Kingwl

Kingwl commented Aug 9, 2021

Copy link
Copy Markdown
Contributor Author

/cc: @hediet

@hediet

hediet commented Aug 9, 2021

Copy link
Copy Markdown
Member

Thanks a lot! I think this method is quite complex. Maybe it makes sense to use await instead of Promise.resolve(...)?

(feel free to do that in another PR)

@hediet hediet merged commit 37f845e into microsoft:main Aug 11, 2021
@hediet hediet added this to the August 2021 milestone Aug 11, 2021
@Kingwl Kingwl deleted the fix_folding_with_inlayhints branch September 8, 2021 03:20
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inlay hints displayed twice for folded functions/objects

3 participants