Support switching to/from custom views in reference-view API#152008
Merged
Conversation
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Contributor
|
Sorry - I have been swapped recently and I am now heading out to a longer vacation. My plan is to finally pick this up in August. Thanks for being patient and happy coding |
Contributor
Author
|
@jrieken never mind, enjoy your vacation!😀 |
jrieken
previously approved these changes
Aug 19, 2022
jrieken
left a comment
jrieken
left a comment
Contributor
There was a problem hiding this comment.
Thanks and sorry for the huge delay here
alexdima
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen chenshi@microsoft.com
This PR fixes #146037
see also: microsoft/vscode-references-view#74, microsoft/vscode-references-view#75
With this change, we can
vscode.Locationexactly) to the currentsetTypeHierarchyDirection()to manipulate the preset type views (supertype view and subtype view). see https://github.com/CsCherrYY/vscode-java/blob/bff041f997a6de0cbba9df243c1b7dc3a6f84006/src/standardLanguageClient.ts#L421-L427 for the usage.