Skip to content

Add config for disable arrows in diff#153199

Merged
alexdima merged 1 commit into
microsoft:mainfrom
Mingpan:mingpan/revert-arrow-setting
Jun 27, 2022
Merged

Add config for disable arrows in diff#153199
alexdima merged 1 commit into
microsoft:mainfrom
Mingpan:mingpan/revert-arrow-setting

Conversation

@Mingpan

@Mingpan Mingpan commented Jun 25, 2022

Copy link
Copy Markdown
Contributor

This PR fixes:

This PR adds a config setting for diff editor. The setting allows user to disable revert change icons in the glyph margin of a side-by-side diff editor.

CC @hediet

Some additional notes:

  • I implemented this in a way that's similar to other existing settings in diffEditorWidget.ts, please let me know if some other pattern is preferred instead.
  • Tooltips for glyph margin icons / decorations is not covered in this PR. A separate issue tracks it.

Please let me know if there's anything in the code that needs fixes / improvements. Thanks!

@hediet hediet requested a review from alexdima June 27, 2022 13:44
@hediet

hediet commented Jun 27, 2022

Copy link
Copy Markdown
Member

Thanks a lot for the PR!

@hediet hediet added this to the June 2022 milestone Jun 27, 2022
@alexdima alexdima merged commit 0a3ca02 into microsoft:main Jun 27, 2022
@masterwishx

Copy link
Copy Markdown

i cant see arrow in diff for copy changes ...

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants