Support codicons in getting started#158173
Merged
Merged
Conversation
lramos15
enabled auto-merge (squash)
August 15, 2022 13:50
miguelsolorio
self-requested a review
August 15, 2022 16:59
Contributor
|
Pushed some updates to clean up the styles for icons since they were really generic before. Here's what it looks like:
And for the edge cases:
|
Member
Author
|
These look great, thanks! I especially like that they're no longer blue |
Contributor
|
Also updated the close button to have hover feedback:
I'm all done and will remove myself as a reviewer |
miguelsolorio
removed their request for review
August 15, 2022 19:30
daviddossett
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154963
This completes the codicon support in all other walkthrough locations
@misolori I think this experience could now use some styling love. The codicons can look a bit out of place. I can fiddle with the CSS some more, but would appreciate your input