Add onDidChangeShell event to the API#160900
Merged
Merged
Conversation
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Tyriar
suggested changes
Sep 14, 2022
Tyriar
left a comment
Tyriar
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Couple of comments and this looks good to go
Comment on lines
+9181
to
+9185
| /** | ||
| * An {@link Event} which fires when the default shell changes. | ||
| */ | ||
| export const onDidChangeShell: Event<string>; | ||
|
|
Contributor
There was a problem hiding this comment.
This needs to move into a vscode.proposed.envShellEvent.d.ts file instead to go through our proposal/finalization process.
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Contributor
Author
|
@Tyriar If you're okay, I can rebase the commits to avoid garbage commits on the main branch. |
Tyriar
reviewed
Sep 14, 2022
Contributor
It's fine as they're all linked to the merge commit, the merger can squash or rebase before merging if they want thought the github UI as well. |
lramos15
requested changes
Sep 14, 2022
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
lramos15
previously approved these changes
Sep 14, 2022
Contributor
Author
Tyriar
previously approved these changes
Sep 14, 2022
Tyriar
enabled auto-merge
September 14, 2022 14:24
lramos15
approved these changes
Sep 14, 2022
Tyriar
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160694