Telemetry: log command execution time#165599
Merged
Merged
Conversation
Monitoring execution time can be useful when investigating performance issues and detecting performance regressions. VS Code already logs the extension activation times (ExtensionActivationTimesClassification). Logging command execution times seems consistent.
jrieken
suggested changes
Nov 8, 2022
jrieken
left a comment
jrieken
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Fixing the classification is important, the nit is optional.
- use try/finally - mark telemetry as measurement
jrieken
approved these changes
Nov 8, 2022
Contributor
|
Thanks @laurentlb |
lramos15
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monitoring execution time can be useful when investigating performance issues and detecting performance regressions.
VS Code already logs the extension activation times (ExtensionActivationTimesClassification). Logging command execution times seems consistent.