Copyedit: “Double-clicking” -> “Double-clicking”#166758
Merged
Merged
Conversation
Tyriar
previously approved these changes
Nov 21, 2022
andreamah
suggested changes
Nov 21, 2022
Member
|
I still see places in the code where the hyphenated version is not used. Can we tackle them all? |
Contributor
|
@sbatten if it's in code/comments it doesn't matter, only user facing matters |
Member
|
@Tyriar I count 17 results in 11 files with user facing strings from a quick search. This PR currently covers 7 files |
I used ^[^*\/\/]+double click to find the non-comment cases
Tyriar
approved these changes
Dec 15, 2022
TylerLeonhardt
approved these changes
Dec 16, 2022
andreamah
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phrase “double-clicking” should almost always be hyphenated.