Skip to content

Fix bug with snippet choices escaping#169287

Merged
jrieken merged 3 commits into
microsoft:mainfrom
pokey:patch-2
Dec 15, 2022
Merged

Fix bug with snippet choices escaping#169287
jrieken merged 3 commits into
microsoft:mainfrom
pokey:patch-2

Conversation

@pokey

@pokey pokey commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

The code that inserts \ to escape text in choices in toTextmateString wasn't escaping \ characters themselves. Fwiw this bug could have been caught by codeql

@pokey

pokey commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@jrieken jrieken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@jrieken jrieken added this to the January 2023 milestone Dec 15, 2022
@jrieken
jrieken merged commit 3375e50 into microsoft:main Dec 15, 2022
@pokey
pokey deleted the patch-2 branch December 15, 2022 18:12
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants