Skip to content

feat(ma-pro-table & ma-remote-select) :#499

Merged
kanyxmo merged 1 commit into
masterfrom
refactor(ma-remote-select)
Dec 17, 2024
Merged

feat(ma-pro-table & ma-remote-select) :#499
kanyxmo merged 1 commit into
masterfrom
refactor(ma-remote-select)

Conversation

@kanyxmo

@kanyxmo kanyxmo commented Dec 17, 2024

Copy link
Copy Markdown
Member
  • ma-pro-table更新到1.0.55版本
  • ma-remote-select 覆盖原组件的change事件
  • ma-remote-select 增加select-item事件,可获取所选项整个数据项
  • ma-remote-select 增加允许是否自动请求
  • ma-remote-select 增加 expose 暴露 el-select-v2 的组件属性 和 组件自定义的 refresh 方法

Summary by CodeRabbit

  • New Features

    • Enhanced ma-remote-select component with an autoRequest property for conditional API requests.
    • New events select-item and change emitted during item selection.
    • Exposed refresh method and selectRef reference for external access.
  • Bug Fixes

    • Updated dependency version for @mineadmin/pro-table to ensure compatibility.
  • Documentation

    • Adjusted TypeScript declarations for auto-imports, removing obsolete types.

- ma-pro-table更新到1.0.55版本
- ma-remote-select 覆盖原组件的change事件
- ma-remote-select 增加select-item事件,可获取所选项整个数据项
- ma-remote-select 增加允许是否自动请求
- ma-remote-select 增加 expose 暴露 el-select-v2 的组件属性 和 组件自定义的 refresh 方法
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 17, 2024
@coderabbitai

coderabbitai Bot commented Dec 17, 2024

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces changes to the MineAdmin UI project, focusing on updating the @mineadmin/pro-table dependency version and modifying the ma-remote-select component. The changes include adding an autoRequest property, introducing new event emissions, and exposing component methods and references. Additionally, a TypeScript declaration file has been updated by removing the MaybeRef and MaybeRefOrGetter types from its exports.

Changes

File Change Summary
web/package.json Updated @mineadmin/pro-table dependency from ^1.0.53 to ^1.0.55
web/src/components/ma-remote-select/index.vue - Added autoRequest prop to axiosConfig
- Introduced select-item and change events
- Added request function for API handling
- Exposed refresh method and elSelectV2Ref
web/types/auto-imports.d.ts Removed DirectiveBinding, MaybeRef, and MaybeRefOrGetter from Vue type exports

Possibly related PRs

  • feat(ma-pro-table & ma-remote-select) : #499: This PR updates the @mineadmin/pro-table dependency from ^1.0.53 to ^1.0.55, which directly matches the version change in the main PR. Additionally, it includes modifications to the ma-remote-select component that are also present in the main PR.

Poem

🐰 A rabbit's tale of code so bright,
Dependencies dancing with delight,
Select components now more free,
Exports trimmed with glee,
MineAdmin's magic takes flight! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7edbe1 and b7ee4ad.

📒 Files selected for processing (3)
  • web/package.json (1 hunks)
  • web/src/components/ma-remote-select/index.vue (2 hunks)
  • web/types/auto-imports.d.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant