Skip to content

fix(workflow): 修正 PHP 版本变量名称为 php-version#657

Merged
zds-s merged 1 commit into
mineadmin:masterfrom
people-sea:fix/workflow-test-cs-fix
Jul 21, 2025
Merged

fix(workflow): 修正 PHP 版本变量名称为 php-version#657
zds-s merged 1 commit into
mineadmin:masterfrom
people-sea:fix/workflow-test-cs-fix

Conversation

@people-sea

@people-sea people-sea commented Jul 21, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • 更新了 GitHub Actions 工作流配置中的变量命名,无影响于功能或用户体验。

@coderabbitai

coderabbitai Bot commented Jul 21, 2025

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

此更改将 GitHub Actions 工作流中 cs-fix 任务的 matrix 变量名从 php 修改为 php-version,并相应更新了所有相关引用。未涉及其他逻辑或步骤的调整。

Changes

文件/路径 变更摘要
.github/workflows/test.yml 将 matrix 变量名由 php 改为 php-version,并更新相关引用。

Suggested labels

size:XS, lgtm

Poem

🐰
变量名轻轻换,
Actions 流程更清晰。
代码如风舞,
测试依旧行。
小小改动间,
质量稳如山。


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or PR title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 21, 2025
@people-sea
people-sea requested a review from Copilot July 21, 2025 02:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes inconsistent variable naming in the GitHub Actions workflow by standardizing the PHP version reference to use php-version throughout the workflow file. The change corrects a mismatch between the matrix variable definition and its usage in the job name.

  • Renamed matrix variable from php to php-version for consistency
  • Updated job name template to reference the corrected variable name

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/test.yml (2)

9-9: 在 job 名称中加入空格,提升可读性
PHP${{ matrix.php-version }} 会渲染成 PHP8.1,数字与文字粘连。建议在 PHP 与版本号之间加入空格,使输出更友好。

-    name: PHP CS Fix on PHP${{ matrix.php-version }} ${{ matrix.swoole }}
+    name: PHP CS Fix on PHP ${{ matrix.php-version }} ${{ matrix.swoole }}

14-14: 保持变量一致:步骤里也应使用 matrix.php-version
虽然当前只有一个版本,但如果以后在 matrix 中追加版本,Setup PHP 步骤仍写死 '8.1' 会导致配置不一致。建议改为引用同一变量。

       with:
-          php-version: '8.1'
+          php-version: ${{ matrix.php-version }}
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc501ca and 0dc5071.

📒 Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)

@people-sea
people-sea requested a review from zds-s July 21, 2025 03:09
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 21, 2025
@zds-s
zds-s merged commit 7bbc5c0 into mineadmin:master Jul 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants