feat(user): 添加删除数据权限功能

[zds-s]

• 在用户管理表单中添加删除数据权限开关
• 实现用户数据权限的删除逻辑- 更新相关语言文件，添加删除数据权限相关翻译

Summary by CodeRabbit

• 新功能

  • 用户管理表单新增“删除数据权限”开关选项，支持通过切换按钮删除用户数据权限策略。
  • 支持英文、简体中文和繁体中文的“删除数据权限”多语言显示。

• 其他

  • 表单验证新增对“删除数据权限”字段的可选布尔校验。

[coderabbitai]

📝 Walkthrough

Walkthrough

本次变更为用户权限管理增加了“删除数据权限”功能。后端增加了对 delete_policy 字段的校验与处理逻辑，前端表单新增了对应的开关项，并在中英文及繁体中文本地化文件中添加了相关翻译。

Changes

Cohort / File(s)	Change Summary
后端校验与服务逻辑 app/Http/Admin/Request/Permission/UserRequest.php, app/Service/Permission/UserService.php	新增 delete_policy 布尔类型校验规则，服务层增加根据该字段删除用户数据权限策略的逻辑。
前端表单配置 web/src/modules/base/views/permission/user/data/getFormItems.tsx	表单项新增 delete_policy 开关，支持本地化标签。
本地化翻译 web/src/modules/base/locales/en[English].yaml, web/src/modules/base/locales/zh_CN[简体中文].yaml, web/src/modules/base/locales/zh_TW[繁體中文].yaml	各语言包下 baseUserManage 节点新增 delete_policy 翻译。

Sequence Diagram(s)

sequenceDiagram
    participant 前端
    participant 后端API
    participant UserService
    participant 数据库

    前端->>后端API: 提交包含 delete_policy 字段的表单
    后端API->>UserService: 传递数据（含 delete_policy）
    UserService-->>数据库: 查询用户现有 policy
    alt delete_policy 为 true
        UserService-->>数据库: 删除 policy
    else
        alt 存在 policy
            UserService-->>数据库: 更新 policy
        else
            UserService-->>数据库: 创建新 policy
        end
    end
    UserService-->>后端API: 返回处理结果
    后端API-->>前端: 返回响应

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

enhancement, size:S

Suggested reviewers

• develop-chen
• kanyxmo

Poem

兔子写代码，权限又升级，
删除策略开关，轻松一指挥。
多语翻译添新词，
表单开关亮晶晶，
审查代码心欢喜，
兔耳朵也竖起来！ 🐰✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch master-department-patch1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or PR title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[zds-s]

related #633

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (3)

app/Http/Admin/Request/Permission/UserRequest.php (1)

100-116: 建议在 attributes 方法中添加字段翻译

为了提供更好的错误消息，建议在 attributes() 方法中为 delete_policy 字段添加翻译。

在 attributes() 方法中添加以下行：

 public function attributes(): array
 {
     return [
         'username' => trans('user.username'),
         'user_type' => trans('user.user_type'),
         'nickname' => trans('user.nickname'),
         'phone' => trans('user.phone'),
         'email' => trans('user.email'),
         'avatar' => trans('user.avatar'),
         'signed' => trans('user.signed'),
         'status' => trans('user.status'),
         'backend_setting' => trans('user.backend_setting'),
         'created_by' => trans('user.created_by'),
         'remark' => trans('user.remark'),
         'department' => trans('user.department'),
+        'delete_policy' => trans('user.delete_policy'),
     ];
 }

web/src/modules/base/views/permission/user/data/getFormItems.tsx (1)

119-129: 表单项实现正确，但考虑优化布局和一致性

表单项实现正确，使用 <el-switch /> 组件处理布尔值是合适的。

建议考虑以下优化：

1. 位置调整：将此字段移到数据权限相关按钮附近，以提高逻辑分组的一致性
2. 标签宽度一致性：检查其他表单项的 labelWidth 设置，保持一致的视觉效果
3. 默认值：考虑为该字段设置默认值（通常为 false）

 if (formType === 'add') {
   model.password = '123456'
   model.status = 1
   model.user_type = 100
   model.department = []
   model.position = []
+  model.delete_policy = false
 }

app/Service/Permission/UserService.php (1)

114-114: 考虑添加删除操作的返回值检查

删除操作可能失败，建议添加适当的错误处理或日志记录。

-                $entity->policy()->delete();
+                $deleteResult = $entity->policy()->delete();
+                // 可选：添加日志记录删除结果
+                if (!$deleteResult) {
+                    // 处理删除失败的情况
+                }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6084869 and 34826d2.

📒 Files selected for processing (6)

• app/Http/Admin/Request/Permission/UserRequest.php (1 hunks)
• app/Service/Permission/UserService.php (1 hunks)
• web/src/modules/base/locales/en[English].yaml (1 hunks)
• web/src/modules/base/locales/zh_CN[简体中文].yaml (1 hunks)
• web/src/modules/base/locales/zh_TW[繁體中文].yaml (1 hunks)
• web/src/modules/base/views/permission/user/data/getFormItems.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

• GitHub Check: Test on PHP8.2 Swoole-v5.0.3
• GitHub Check: Test on PHP8.1 Swow-develop
• GitHub Check: Test on PHP8.1 Swoole-master
• GitHub Check: Test on PHP8.3 Swoole-v5.1.5
• GitHub Check: Test on PHP8.2 Swow-develop
• GitHub Check: Test on PHP8.2 Swoole-v5.1.5
• GitHub Check: Test on PHP8.3 Swow-develop
• GitHub Check: build Code coverage report (ubuntu-latest, 8.1, v5.1.3)
• GitHub Check: Test on PHP8.1 Swoole-master
• GitHub Check: Test on PHP8.3 Swoole-master
• GitHub Check: Test on PHP8.2 Swoole-v5.0.3
• GitHub Check: Test on PHP8.2 Swoole-master
• GitHub Check: Test on PHP8.1 Swoole-v5.1.5
• GitHub Check: Test on PHP8.1 Swoole-v5.0.3
• GitHub Check: Test on PHP8.3 Swoole-v5.1.5
• GitHub Check: Test on PHP8.2 Swoole-v5.1.5
• GitHub Check: Test on PHP8.3 Swow-develop
• GitHub Check: Test on PHP8.1 Swow-develop
• GitHub Check: Test on PHP8.2 Swow-develop
• GitHub Check: build Code coverage report (ubuntu-latest, 8.1, v5.1.3)

🔇 Additional comments (3)

web/src/modules/base/locales/en[English].yaml (1)

20-20: LGTM!

英文本地化字符串添加正确，命名规范且翻译准确。

web/src/modules/base/locales/zh_CN[简体中文].yaml (1)

22-22: LGTM!

简体中文本地化字符串添加正确，翻译准确且符合中文表达习惯。

app/Http/Admin/Request/Permission/UserRequest.php (1)

69-69: LGTM!

验证规则添加正确，使用了合适的 sometimes|bool 规则来处理可选的布尔值字段。