Update(CI): update swoole version in test matrix to v5.1.8#692
Conversation
📝 WalkthroughWalkthrough将 GitHub Actions 工作流 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/test.yml (1)
164-167: tests-swow 的 exclude 规则无效(排除了不存在于该矩阵的组合)swow 矩阵只有 sw-version: develop,但这里排除了 sw-version: v5.0.3,属于遗留无效配置,建议移除以避免误导。
建议直接删除该块:
exclude: - - php-version: '8.3' - sw-version: 'v5.0.3'
🧹 Nitpick comments (2)
.github/workflows/test.yml (2)
38-43: cs-fix 任务 PHP 版本声明与实际安装不一致(名称/矩阵是 8.3,但实际装的是 8.1)为避免混淆,建议统一用矩阵变量。另,cs-fix 不需要 Swoole 扩展,可精简安装以加快速度。
请参考以下最小改动:
with: - php-version: '8.1' + php-version: ${{ matrix.php-version }} tools: php-cs-fixer extensions: ${{ env.PHP_EXTENSIONS }}可选精简(进一步减少不必要的扩展安装):
- env: - PHP_EXTENSIONS: redis, pdo, pdo_mysql, sqlsrv, pdo_sqlsrv, pdo_odbc, bcmath, swoole-${{ matrix.sw-version }} + env: + PHP_EXTENSIONS: none
65-65: 建议将 matrix 中的 “master” 替换为固定 tag 或 commit SHA已确认 v5.1.8 tag 存在且可下载(HTTP 302),可合并;为避免上游主分支变更引发 CI 偶发失败,请在
.github/workflows/test.yml:65将master替换为具体稳定版本或 commit SHA。
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: People-Sea
PR: mineadmin/MineAdmin#669
File: .github/workflows/test.yml:30-34
Timestamp: 2025-07-26T18:23:52.695Z
Learning: 在 MineAdmin 项目的 GitHub Actions 工作流中,cs-fix job 应该只执行一次,不需要跨多个 PHP 版本进行矩阵构建,因为代码风格检查只需要在一个固定的 PHP 版本上运行即可。
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: Test on PHP8.2 Swoole-master
- GitHub Check: Test on PHP8.2 Swoole-v6.0.2
- GitHub Check: Test on PHP8.1 Swoole-v5.0.3
- GitHub Check: Test on PHP8.2 Swoole-v5.1.8
- GitHub Check: Test on PHP8.1 Swoole-v5.1.8
- GitHub Check: Test on PHP8.1 Swoole-master
- GitHub Check: Test on PHP8.1 Swoole-v6.0.2
- GitHub Check: Test on PHP8.2 Swoole-v5.0.3
- GitHub Check: Test on PHP8.3 Swoole-v5.1.8
- GitHub Check: Test on PHP8.3 Swoole-master
- GitHub Check: Test on PHP8.3 Swoole-v6.0.2
- GitHub Check: Test on PHP8.1 Swow-develop
- GitHub Check: Test on PHP8.2 Swow-develop
- GitHub Check: Test on PHP8.3 Swow-develop
Summary by CodeRabbit