Skip to content

Update(CI): update swoole version in test matrix to v5.1.8#692

Merged
people-sea merged 1 commit into
mineadmin:masterfrom
people-sea:update/ci/swoole-v-5.1.8
Sep 6, 2025
Merged

Update(CI): update swoole version in test matrix to v5.1.8#692
people-sea merged 1 commit into
mineadmin:masterfrom
people-sea:update/ci/swoole-v-5.1.8

Conversation

@people-sea

@people-sea people-sea commented Sep 6, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • 测试
    • 更新测试矩阵,采用 Swoole v5.1.8 运行 CI 测试。
  • 杂务
    • 本次变更不影响用户功能或接口。

@boring-cyborg boring-cyborg Bot added the GitHub label Sep 6, 2025
@people-sea
people-sea marked this pull request as ready for review September 6, 2025 13:10
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 6, 2025
@coderabbitai

coderabbitai Bot commented Sep 6, 2025

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

将 GitHub Actions 工作流 .github/workflows/test.yml 中 tests-swoole 的 Swoole 版本矩阵由 v5.1.6 更新为 v5.1.8,其他版本与排除规则不变。

Changes

Cohort / File(s) Change Summary
CI 工作流矩阵更新
.github/workflows/test.yml
更新 tests-swoole 矩阵:Swoole 版本从 v5.1.6 调整为 v5.1.8;其余版本(v5.0.3、v6.0.2、master)与 exclude 块保持不变。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

size:XS

Suggested reviewers

  • zds-s

Poem

小兔拍爪跳一跳,
测试矩阵轻轻调。
5.1.6 说再见,5.1.8 来报到。
CI 转轮不打扰,
绿灯亮起心不焦。 🐇✅

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the dependencies Pull requests that update a dependency file label Sep 6, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/test.yml (1)

164-167: tests-swow 的 exclude 规则无效(排除了不存在于该矩阵的组合)

swow 矩阵只有 sw-version: develop,但这里排除了 sw-version: v5.0.3,属于遗留无效配置,建议移除以避免误导。

建议直接删除该块:

       exclude:
-          - php-version: '8.3'
-            sw-version: 'v5.0.3'
🧹 Nitpick comments (2)
.github/workflows/test.yml (2)

38-43: cs-fix 任务 PHP 版本声明与实际安装不一致(名称/矩阵是 8.3,但实际装的是 8.1)

为避免混淆,建议统一用矩阵变量。另,cs-fix 不需要 Swoole 扩展,可精简安装以加快速度。

请参考以下最小改动:

       with:
-          php-version: '8.1'
+          php-version: ${{ matrix.php-version }}
           tools: php-cs-fixer
           extensions: ${{ env.PHP_EXTENSIONS }}

可选精简(进一步减少不必要的扩展安装):

-    env:
-      PHP_EXTENSIONS: redis, pdo, pdo_mysql, sqlsrv, pdo_sqlsrv, pdo_odbc, bcmath, swoole-${{ matrix.sw-version }}
+    env:
+      PHP_EXTENSIONS: none

65-65: 建议将 matrix 中的 “master” 替换为固定 tag 或 commit SHA

已确认 v5.1.8 tag 存在且可下载(HTTP 302),可合并;为避免上游主分支变更引发 CI 偶发失败,请在 .github/workflows/test.yml:65master 替换为具体稳定版本或 commit SHA。

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09c8d92 and e07841a.

📒 Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: People-Sea
PR: mineadmin/MineAdmin#669
File: .github/workflows/test.yml:30-34
Timestamp: 2025-07-26T18:23:52.695Z
Learning: 在 MineAdmin 项目的 GitHub Actions 工作流中,cs-fix job 应该只执行一次,不需要跨多个 PHP 版本进行矩阵构建,因为代码风格检查只需要在一个固定的 PHP 版本上运行即可。
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: Test on PHP8.2 Swoole-master
  • GitHub Check: Test on PHP8.2 Swoole-v6.0.2
  • GitHub Check: Test on PHP8.1 Swoole-v5.0.3
  • GitHub Check: Test on PHP8.2 Swoole-v5.1.8
  • GitHub Check: Test on PHP8.1 Swoole-v5.1.8
  • GitHub Check: Test on PHP8.1 Swoole-master
  • GitHub Check: Test on PHP8.1 Swoole-v6.0.2
  • GitHub Check: Test on PHP8.2 Swoole-v5.0.3
  • GitHub Check: Test on PHP8.3 Swoole-v5.1.8
  • GitHub Check: Test on PHP8.3 Swoole-master
  • GitHub Check: Test on PHP8.3 Swoole-v6.0.2
  • GitHub Check: Test on PHP8.1 Swow-develop
  • GitHub Check: Test on PHP8.2 Swow-develop
  • GitHub Check: Test on PHP8.3 Swow-develop

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Sep 6, 2025
@people-sea
people-sea merged commit bc8bb38 into mineadmin:master Sep 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file GitHub lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants