add blocklist/block api#13737
Conversation
8249bcb to
f57a83b
Compare
| if ('request' in self.context and | ||
| 'wrap_outgoing_links' in self.context['request'].GET and | ||
| 'url' in data): | ||
| data['url'] = get_outgoing_url(data['url']) |
There was a problem hiding this comment.
I am curious: are we doing this in every serializer that needs to support wrap_outgoing_links? Don't we have a mixin or something for that?
There was a problem hiding this comment.
we don't, but each serializer does something slightly different (AddonSerializer has to handle l10n, and hero shelves is already a mixin that deals with the CTA text also)
| min_version='45', | ||
| reason='something happened', | ||
| url='https://goo.gol', | ||
| updated_by=user_factory()) |
There was a problem hiding this comment.
Maybe you could create a setUp() method and define the block there?
willdurand
left a comment
willdurand
left a comment
There was a problem hiding this comment.
Sorry, I forgot to ask the following question: in both the frontend and server issues, we mention a "version" but I don't see anything related to versions in this patch. What's the plan?
According to mozilla/addons#13681, there is no need to specify a |
2 participants
fixes mozilla/addons#7386