Add is_developer_reply property to ratings API responses#9099
Merged
Conversation
diox
commented
Aug 7, 2018
| https://github.com/mozilla/addons-server/issues/8794 | ||
| * 2018-07-18: added ``previews`` property to discovery API ``addons`` object. This change was also backported to the `v3` API. https://github.com/mozilla/addons-server/issues/8863 | ||
| * 2018-07-20: dropped ``downloads`` property from the collection add-ons results. https://github.com/mozilla/addons-server/issues/8944 | ||
| * 2018-08-09: added ``is_developer_reply`` property to ratings. This changed was also backported to the `v3` API. https://github.com/mozilla/addons-server/issues/8993 |
Member
Author
There was a problem hiding this comment.
Will update as it won't make the tag.
Member
There was a problem hiding this comment.
The sooner we get #8899 done the sooner we can stop this risky modification of the "frozen" v3 API 😿
eviljeff
approved these changes
Aug 8, 2018
| https://github.com/mozilla/addons-server/issues/8794 | ||
| * 2018-07-18: added ``previews`` property to discovery API ``addons`` object. This change was also backported to the `v3` API. https://github.com/mozilla/addons-server/issues/8863 | ||
| * 2018-07-20: dropped ``downloads`` property from the collection add-ons results. https://github.com/mozilla/addons-server/issues/8944 | ||
| * 2018-08-09: added ``is_developer_reply`` property to ratings. This changed was also backported to the `v3` API. https://github.com/mozilla/addons-server/issues/8993 |
Member
There was a problem hiding this comment.
The sooner we get #8899 done the sooner we can stop this risky modification of the "frozen" v3 API 😿
| 'slug': addon.slug | ||
| } | ||
|
|
||
| def get_is_developer_reply(self, obj): |
Member
There was a problem hiding this comment.
observation: a property that could be on the Rating model itself. Not that it'd give us anything extra, really.
Member
Author
There was a problem hiding this comment.
Yeah, I've looked through the code and we wouldn't really make use of that property anywhere. Generally we care more about the fact that a rating has a reply than the fact that it is a reply.
This was referenced Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mozilla/addons#5840