Skip to content

General error: 25 bind or column index out of range fix#46

Closed
hubipe wants to merge 1 commit into
nette:masterfrom
hubipe:journal-array-fix
Closed

General error: 25 bind or column index out of range fix#46
hubipe wants to merge 1 commit into
nette:masterfrom
hubipe:journal-array-fix

Conversation

@hubipe

@hubipe hubipe commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

When called SQLiteJournal::clean method with non-consequent integer keys, method execute had thrown exception General error: 25 bind or column index out of range.

@dg

dg commented Oct 5, 2016

Copy link
Copy Markdown
Member

I feel that there are other places in SQLiteStorage and SQLiteJournal that should be fixed. Maybe it would be better to fix it in Cache::clean() and Cache::completeDependencies().

@hubipe

hubipe commented Oct 5, 2016

Copy link
Copy Markdown
Contributor Author

All right, I have just changed the casting to array list in Cache. Unfortunately, there are three errors in tests, because when trying to write dependency as a string, it is converted to array list. Tests expects it to be string though, therefore it fails. I'm not sure, if this is a problem of tests or expected behaviour.

Wouldn't it be better then, to cast tags to array list inside SQLiteStorage and SQLiteJournal only?

@hubipe hubipe closed this Oct 5, 2016
@hubipe hubipe reopened this Oct 5, 2016
@dg

dg commented Oct 6, 2016

Copy link
Copy Markdown
Member

IMHO this is correct solution because storages currently rely on normalized dependencies. So it is only other normalization.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants