feat: allow use of text/plain for script tag#282
Merged
Conversation
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Feb 17, 2022
dg
pushed a commit
that referenced
this pull request
Feb 18, 2022
dg
pushed a commit
that referenced
this pull request
Feb 18, 2022
dg
pushed a commit
that referenced
this pull request
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For GDPR usage most scripts must be set as
text/plain, but latte doesn't handle types in variables with this type.eg. here - https://orestbida.com/demo-projects/cookieconsent/
This PR fixes it, but might cause bc break, if anyone used the
text/plainand inserted quotes manualyeg.
Do not place {$test} inside quotes in .../templates/@layout.latte:20But this change is definitely needed, because if you would want to make the cookieconsent for scripts conditional, there would be problems with the js variables being or not being processed with latte.