Add failing test for array

[Nek-]

• bug fix (that is only bug exposition ATM)
• BC break? no

Hello, I found this bug :(.

[dg]

I can't see it.

[Nek-]

@dg what can't you see? (the test failure is not good enough for you?)

I was not able to make a good fix for it :/.

[JanTvrdik]

The current behavior is intentional. See

php-generator/src/PhpGenerator/Dumper.php

Line 102 in fd5e55c

$keyPart = $k === $counter ? '' : $this->dumpVar($k) . ' => ';

Maybe there should be an option to disable this?

[dg]

Ok I get it. But it's not a bug, just a cosmetic thing because [606990006 => 'bar', 606990007 => 'baz'] is the same as [606990006 => 'bar', 'baz'].

[Nek-]

@dg absolutely. But this is also assuming PHP behaves like that, which is weird. And I think all weird stuff should not be considered as "this is good".

Of course, it's also extremely disturbing for people that will use generated classes, that's mostly why I'm suggesting to support this.

An option is probably the better idea, yes :).

[dg]

I would not call it a weird, it is a documented standard behavior that I like to use, for example in $months = [1 => 'January', 'February', 'March', 'April', 'May', 'June', ...]. But I understand that in the dumps where most keys are present, the missing ones are confusing.