Ability to set whether bluescreen panel is collapsed or not#232
Merged
Conversation
JanTvrdik
suggested changes
Oct 30, 2016
| <?php $bottomPanels = [] ?> | ||
| <?php foreach ($this->renderPanels(NULL) as $panel): ?> | ||
| <?php if (!empty($panel->bottom)) { $bottomPanels[] = $panel; continue; } ?> | ||
| <?php $collapsed = isset($panel->collapsed) ? (bool) $panel->collapsed : true; ?> |
Contributor
There was a problem hiding this comment.
the (bool) cast is unnecessary; true should be written in uppercase (TRUE)
Member
There was a problem hiding this comment.
Maybe it is better to create $collapseClass than bool $collapse
Contributor
Author
There was a problem hiding this comment.
Bool cast removed.
Used $collapseClass.
JanTvrdik
suggested changes
Oct 30, 2016
| <?php $bottomPanels = [] ?> | ||
| <?php foreach ($this->renderPanels(NULL) as $panel): ?> | ||
| <?php if (!empty($panel->bottom)) { $bottomPanels[] = $panel; continue; } ?> | ||
| <?php $collapsedClass = (isset($panel->collapsed) ? $panel->collapsed : TRUE) ? ' tracy-collapsed' : ''; ?> |
Contributor
There was a problem hiding this comment.
Can be simplified to
$collapsedClass = !isset($panel->collapsed) || $panel->collapsed ? ' tracy-collapsed' : '';
Contributor
Author
There was a problem hiding this comment.
Done.
Anything else? :-)
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request is to give user-defined panels in bluescreen possibility to declare whether they want to be collapsed or expanded.
Now, if you implement Bluescreen panel, you must return from your callback array with two keys -
panelandtab. After this PR we will support third optional key -collapsed.