remove --rpath-wrapper-dir configuration option + copy rpath_args.py script to avoid that RPATH wrapper scripts rely on external script#47
Merged
ocaisa merged 7 commits intoApr 23, 2025
Conversation
…ing rpath_args.py into it
…m location for RPATH wrapper scripts is specified
This was referenced Apr 23, 2025
ocaisa
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ocaisa for easybuilders#4596, as discussed
Tested with updated version of
buildenveasyblock (cfr. easybuilders/easybuild-easyblocks#3661)I'm only copying
rpath_args.pyand using a relative path to it when a location for the RPATH wrapper scripts is specified viaself.rpath_wrappers_dir, out of abundance of caution (thedirname $0bit in the RPATH wrapper template makes me a bit nervous, but I couldn't find a way to make that not work as expected).