Support more data sources#22
Conversation
…/pygwalker-bike-sharing-app
…alker-bike-sharing-app
| @@ -0,0 +1,72 @@ | |||
| from typing import TYPE_CHECKING, Any, Union | |||
There was a problem hiding this comment.
This is one of the key changes. Adding support for more general Tabulator data than pandas DataFrame via Narwhals.
| return [_infer_prop(data[col], i) for i, col in enumerate(data.columns)] | ||
|
|
||
|
|
||
| @nw.narwhalify |
There was a problem hiding this comment.
Here I also used narwhals. Could be performance optimized. But I spent quite a lot of time just getting it working.
|
This one is ready for review. I will create a new branch from this one. Trying to get duckdb relation and pygwalker Connector working. |
|
There are some issues on current main branch when testing pycafe. will fix in this one also. |
MarcSkovMadsen
changed the title
|
Ok. I fixed the issues except #36. |
MarcSkovMadsen
changed the title
| from typing import TYPE_CHECKING, Any, Dict, List, Optional, Protocol | ||
|
|
||
| import pandas as pd | ||
| from sqlalchemy import create_engine, text |
There was a problem hiding this comment.
I don't think this should be imported at the top-level if it can be avoided.
philippjfr
left a comment
philippjfr
left a comment
There was a problem hiding this comment.
Mostly happy with this but I don't think sqlalchemy should be a core dependency.
|
Ignore me, I see it's a pygwalker dependency. |
2 participants
Continues from #32. So review that one first.
Just wanted to get this started.
Feel free to contribute or run with it.