Skip to content

feat: Add obfuscation option#4

Merged
petercinibulk merged 3 commits into
petercinibulk:mainfrom
ThexXTURBOXx:main
Aug 12, 2022
Merged

feat: Add obfuscation option#4
petercinibulk merged 3 commits into
petercinibulk:mainfrom
ThexXTURBOXx:main

Conversation

@ThexXTURBOXx

@ThexXTURBOXx ThexXTURBOXx commented Aug 7, 2022

Copy link
Copy Markdown
Contributor

Since envify seems to have been abandoned and @techouse pointed me to this project, I will offer you my obfuscation option also here :)
For reference: frencojobs/envify#28

@ThexXTURBOXx
ThexXTURBOXx force-pushed the main branch 3 times, most recently from 8021619 to 8137c09 Compare August 8, 2022 06:41
@ThexXTURBOXx ThexXTURBOXx changed the title Add obfuscation option feat: Add obfuscation option Aug 8, 2022
@ThexXTURBOXx

Copy link
Copy Markdown
Contributor Author

I just noticed: We could also add the obfuscate option to the EnviedField annotation to allow for individual field obfuscation.
Right now I am very stressed out. I will try to implement this as soon as I have done free time, though (Mabye also in an extra PR?)

@codecov

codecov Bot commented Aug 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4 (8137c09) into main (dfc26ac) will decrease coverage by 35.76%.
The diff coverage is 7.69%.

❗ Current head 8137c09 differs from pull request most recent head e5a0057. Consider uploading reports for the commit e5a0057 to get more accurate results

@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
- Coverage   98.38%   62.62%   -35.77%     
===========================================
  Files           4        5        +1     
  Lines          62       99       +37     
===========================================
+ Hits           61       62        +1     
- Misses          1       37       +36     
Impacted Files Coverage Δ
...ied_generator/lib/src/generate_line_encrypted.dart 0.00% <0.00%> (ø)
packages/envied/lib/src/envied_base.dart 100.00% <100.00%> (ø)
packages/envied_generator/lib/src/generator.dart 96.00% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@petercinibulk

petercinibulk commented Aug 9, 2022

Copy link
Copy Markdown
Owner

@ThexXTURBOXx I love this! Obfuscation was something I was looking to add but hadn't had the time recently. Thanks! Can you add tests for these changes before I merge?

@petercinibulk

petercinibulk commented Aug 9, 2022

Copy link
Copy Markdown
Owner

Also, I think we can merge this in and do a follow on PR for obfuscation per field

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor Author

Thank you very much for considering this! :)
Alas, I am currently not at home. I will try to finish the tests (and maybe even per-field obfuscation) until Monday, though!

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor Author

@petercinibulk I was able to fit this in today :)
Hope, everything is okay now! Per-field obfuscation is also already working!

@petercinibulk
petercinibulk merged commit 08b6f82 into petercinibulk:main Aug 12, 2022
@petercinibulk

Copy link
Copy Markdown
Owner

@ThexXTURBOXx Thanks for getting that done! I went ahead and merged it in. I need to clean up the readme, so I will do my updates and add some information on using the obfuscation flag next week and then make a release.

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor Author

Hi, are there any updates on this? :)

@petercinibulk

Copy link
Copy Markdown
Owner

Sorry about that. I just pushed a new release.

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor Author

Thank you very much for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants