3d: use custom .clang-format assumed to exist in output directory#186
Merged
Conversation
… with `--makefile`
…stead of copying from EverParse
… be used with `--makefile`" This reverts commit ce031bd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far with
--clang_format, 3D copies the style configuration file from https://github.com/project-everest/everparse/blob/master/src/3d/.clang-format into the output directory specified by--odir.This PR introduces
--clang_format_use_custom_configto skip that copy. Instead, 3D will assume that a.clang-formatfile already exists in the output directory. In particular, the Makefile generated by--makefilewill still add.clang-formatto the prerequisites of.cand.hfiles, but will no longer generate a rule to produce/copy it.