fix #664

[reaperhulk]

No description provided.

[alex]

a) Why don't the tests catch this?
b) If these values are going to be unicode, please make _CRYPTOGRAPHY_MANYLINUX1_CA_DIR unicode.

[reaperhulk]

Tests didn't catch this because to have it take the fallback path we fetched the values from cffi and then monkeypatched our constants (https://github.com/pyca/pyopenssl/blob/master/tests/test_ssl.py#L1114-L1142). So the comparison succeed since they were both bytes.

I think a better fix here is just to declare these as byte strings and not unicode. They're not really paths to us, just sentinel values.

[alex]

That's also fine with me.

[codecov]

Codecov Report

Merging #665 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #665   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          18       18           
  Lines        5737     5737           
  Branches      401      401           
=======================================
  Hits         5562     5562           
  Misses        117      117           
  Partials       58       58

Impacted Files	Coverage Δ
src/OpenSSL/SSL.py	94.88% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5610c...4041f61. Read the comment docs.

[alex]

trailing whitespace makes the flake8 fail

[reaperhulk]

Why can't GitHub's editor strip trailing whitespace like my vim config does.

[alex]

Send a feature request!