Skip to content

[3.8] bpo-21131: Fix faulthandler.register(chain=True) stack (GH-15276)#15291

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-ac827ed-3.8
Aug 14, 2019
Merged

[3.8] bpo-21131: Fix faulthandler.register(chain=True) stack (GH-15276)#15291
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-ac827ed-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

faulthandler now allocates a dedicated stack of SIGSTKSZ*2 bytes,
instead of just SIGSTKSZ bytes. Calling the previous signal handler
in faulthandler signal handler uses more than SIGSTKSZ bytes of stack
memory on some platforms.
(cherry picked from commit ac827ed)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue21131

faulthandler now allocates a dedicated stack of SIGSTKSZ*2 bytes,
instead of just SIGSTKSZ bytes. Calling the previous signal handler
in faulthandler signal handler uses more than SIGSTKSZ bytes of stack
memory on some platforms.
(cherry picked from commit ac827ed)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b8e6824 into python:3.8 Aug 14, 2019
@miss-islington miss-islington deleted the backport-ac827ed-3.8 branch August 14, 2019 22:02
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants