Improve interaction between --local-partial-types and hashability#20719
Merged
Conversation
hauntsaninja
force-pushed
the
localpartialhash
branch
2 times, most recently
from
59da668 to
c5b4ccd
Compare
hauntsaninja
force-pushed
the
localpartialhash
branch
from
c5b4ccd to
288f50d
Compare
This comment has been minimized.
This comment has been minimized.
hauntsaninja
force-pushed
the
localpartialhash
branch
from
1d27cc1 to
420ac8c
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Feb 2, 2026
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
It's a bit ad hoc, but seems benign enough.
| is_lvalue_member=isinstance(lvalue, MemberExpr), | ||
| ) | ||
| and not ( | ||
| self.scope.active_class() |
Collaborator
There was a problem hiding this comment.
Add comment briefly explaining the special case. This could seem mysterious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, we would reveal
list[Hashable]in the test caseThis isn't a great fix though...