fix: coerce default http2.connect port to a number#117
Merged
Conversation
http2.connect() with no explicit port (e.g. "https://host") shipped port: "" to the sidecar, because WHATWG URL.port is the empty string for protocol-default ports and ?? only falls back on null/undefined. The sidecar then failed to deserialize "" into Option<u16>: ERR_AGENTOS_NODE_SYNC_RPC: net.http2_session_connect payload must be valid JSON: invalid type: string "", expected u16 Coerce the raw port to a number, mapping ""/undefined/null to undefined so the field is omitted. The sidecar already defaults an absent port via url.port()/80, so no Rust change is required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-117
railway-app
Bot
temporarily deployed
to
rivet-frontend / secure-exec-pr-117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http2.connect() with no explicit port shipped
port: ""to the sidecar (WHATWG URL.port is the empty string for protocol-default ports, and??only falls back on null/undefined). The sidecar then failed to deserialize""intoOption<u16>:Coerce the raw port to a number, mapping ""/undefined/null to undefined so the field is omitted. The sidecar already defaults an absent port via url.port()/scheme, so no Rust change is required. Fixes AWS Bedrock (HTTP/2 via @smithy/node-http-handler) connections.