fix: repair main after #124 (rustfmt 1.96.0 + userland_code test ctors + clippy)#127
Merged
Merged
Conversation
…t ctors + clippy) #124 (perf: agent-SDK heap snapshot) landed while its CI was red, leaving main failing on fmt, clippy, and 13 missing-field/unused test-compile errors. Repair: - rustfmt 1.96.0: reformat embedded_runtime.rs, snapshot.rs, sidecar/execution.rs, javascript_v8.rs (chain/closure collapse the pinned toolchain expects). - userland_code: add the WarmSnapshot/Execute snapshot field (#124) to 11 ipc_binary BinaryFrame test constructors + 2 embedded_runtime_session frames (empty = bridge-only, the documented default); update the hand-built WarmSnapshot trailing-byte test for the new 2-field wire layout. - clippy -D warnings: checked_div in queue_tracker, is_multiple_of in sidecar/execution, while-let in the js backpressure test, and allow(dead_code) on the host_dir test's source-included module (SessionModuleReader is used elsewhere in the crate). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-127
railway-app
Bot
temporarily deployed
to
rivet-frontend / secure-exec-pr-127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #124 (
perf: cut create-session latency via agent-SDK heap snapshot, merged in2e95d518) landed while its CI was red, leavingmainfailing on three gates:embedded_runtime.rs,snapshot.rs,sidecar/execution.rsunformatted under the pinned toolchain.-D warnings—manual_div,is_multiple_of,while let, and a source-included dead-code false positive.BinaryFrame/SessionMessage/RuntimeCommandconstructors missing the newuserland_codefield; one hand-builtWarmSnapshotbyte test still on the old 1-field wire layout.Every open PR's CI inherits this via the merge commit, so
mainwas blocking the whole repo.What
userland_code(empty = bridge-only, the documented default) to the 11ipc_binarytest frames + 2embedded_runtime_sessionframes; update theWarmSnapshottrailing-byte test for the 2-field (bridge_code+userland_code) wire layout.checked_div(queue_tracker),is_multiple_of(sidecar/execution),while let(js backpressure test),#[allow(dead_code)]on thehost_dirtest'sinclude!d module (SessionModuleReaderis used elsewhere in the crate).Verification (local)
cargo fmt --check(rustfmt 1.96.0) clean ·cargo clippy --workspace --all-targets -- -D warningsclean · ipc_binary (51), embedded_runtime_session, javascript_v8_suite (incl. the #122/#123 regression tests), queue_tracker, kernel gauges, sidecar completion all pass.