fix(agent): mount @agentclientprotocol/sdk for pi and claude adapters#135
Merged
Conversation
- The pi and claude ACP adapters import `@agentclientprotocol/sdk`, but it was missing from each agent descriptor's `requires`, so it was never projected into the VM at `/root/node_modules`. - On runtimes whose module resolver does not fall back to the host tree, the adapter exits code 1 with "Cannot resolve module '@agentclientprotocol/sdk'" (reported against `@agentos-software/claude-code@0.2.0`). - Add it to `requires` for both agents so it is mounted regardless of resolver/runtime version; both packages already declare it as a dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-135
railway-app
Bot
temporarily deployed
to
rivet-frontend / secure-exec-pr-135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@agentclientprotocol/sdk, but it is missing from each agent descriptor'srequires, so it is never projected into the VM at/root/node_modules. On runtimes whose module resolver does not fall back to the host tree, the adapter exits code 1 withCannot resolve module '@agentclientprotocol/sdk'— the failure reported against@agentos-software/claude-code@0.2.0.@agentclientprotocol/sdktorequiresfor bothregistry/agent/claudeandregistry/agent/pi. Both packages already declare it as a dependency, so it resolves on the host and gets mounted into the VM.requires, the VM probe shows/root/node_modules/@agentclientprotocol/sdkis now present (was MISSING); the claude session runs end-to-end on current@rivet-dev/agentos-core, across npm/pnpm/yarn/bun.index.ts(the descriptorrequires). It does not overlap the in-flight adapter-robustness work onstack/fix-agent-adapters-robustness-fixes-to-pi-claude-acp-adapters, which modifiesadapter.ts/package.json/tests.🤖 Generated with Claude Code