fix(example): native-client uses current CreateVmConfig (unblocks CI)#84
Merged
Conversation
|
🚅 Environment secure-exec-pr-84 in rivet-frontend has no services deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
native-clientexample failed to type-check after the "CreateVm → typed JSON config" migration:This is a pre-existing build break on
main, surfaced by the pnpm CI fix that now actually type-checks the workspace examples.Why it broke
createVm's second argument changed from a flat{ runtime, metadata }shape to{ runtime, config: CreateVmConfig }. The old per-VMmetadatafield no longer exists onCreateVmConfig— session metadata now lives onauthenticateAndOpenSession(metadata), which the example already passes ({ example: "native-client" }). The example was simply never updated to the newconfigshape.Change
Replace the stale
metadataobject oncreateVmwith a minimal validCreateVmConfig(ephemeral root filesystem over the bundled base filesystem, empty env, no loopback-exempt ports). Session metadata is unchanged and still passed toauthenticateAndOpenSession. Diff is limited to the example.Verification
pnpm --filter @secure-exec/example-native-client build(tsc) — greenpnpm check-typesacross the workspace — 59/59 packages pass