Skip to content

fix(example): native-client uses current CreateVmConfig (unblocks CI)#84

Merged
NathanFlurry merged 1 commit into
mainfrom
fix/example-native-client
Jun 19, 2026
Merged

fix(example): native-client uses current CreateVmConfig (unblocks CI)#84
NathanFlurry merged 1 commit into
mainfrom
fix/example-native-client

Conversation

@NathanFlurry

@NathanFlurry NathanFlurry commented Jun 19, 2026

Copy link
Copy Markdown
Member

What

The native-client example failed to type-check after the "CreateVm → typed JSON config" migration:

examples/native-client/src/index.ts(15,3): error TS2353: Object literal may only specify known properties, and 'metadata' does not exist in type '{ runtime: GuestRuntimeKind; config: CreateVmConfig; }'

This is a pre-existing build break on main, surfaced by the pnpm CI fix that now actually type-checks the workspace examples.

Why it broke

createVm's second argument changed from a flat { runtime, metadata } shape to { runtime, config: CreateVmConfig }. The old per-VM metadata field no longer exists on CreateVmConfig — session metadata now lives on authenticateAndOpenSession(metadata), which the example already passes ({ example: "native-client" }). The example was simply never updated to the new config shape.

Change

Replace the stale metadata object on createVm with a minimal valid CreateVmConfig (ephemeral root filesystem over the bundled base filesystem, empty env, no loopback-exempt ports). Session metadata is unchanged and still passed to authenticateAndOpenSession. Diff is limited to the example.

Verification

  • pnpm --filter @secure-exec/example-native-client build (tsc) — green
  • pnpm check-types across the workspace — 59/59 packages pass

@railway-app

railway-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

🚅 Environment secure-exec-pr-84 in rivet-frontend has no services deployed.

@NathanFlurry NathanFlurry merged commit bfebe66 into main Jun 19, 2026
1 of 2 checks passed
@NathanFlurry NathanFlurry deleted the fix/example-native-client branch June 19, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant