Add the ability to delete multiple columns#4
Merged
Conversation
kou
reviewed
Feb 3, 2018
| # mode indices refer to rows and everything else is assumed to be a column | ||
| # header. Use by_col!() or by_row!() to force the lookup. | ||
| # | ||
| def delete(index_or_header) |
Member
There was a problem hiding this comment.
*indexes_or_headeres is better than accepting an Array argument.
kou
reviewed
Feb 3, 2018
| def delete(index_or_header) | ||
| if @mode == :row or # by index | ||
| if index_or_header.is_a? Array # by array of headers | ||
| index_or_header.each do |element| |
Member
There was a problem hiding this comment.
This method should return the deleted objects.
indexes_or_headers.map do |index_or_header|
delete(index_or_header)
end
Contributor
Author
|
@kou Thanks for review and I changed checked methods. Can you view current version please? |
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was working with some statistics using Ruby/csv, I discovered that the mechanism for deleting columns is very peculiar in Ruby and we can't easily just delete more than 1 column.
We can do it like this (DRY):
Or like this (will destroy csv structure -> Array of Arrays):
And finally the best working way for me:
But I think it should work easily like this:
So I rewrote method a little and added this functionality. If you have any ideas: create another
delete_columnsmethod or maybe better ways to fast delete columns, I will be glad to hear it:)