Skip to content

Do not use a disabled-option in the docs#5973

Merged
bors merged 2 commits into
rust-lang:masterfrom
lostiniceland:5717-update-docs
Sep 4, 2018
Merged

Do not use a disabled-option in the docs#5973
bors merged 2 commits into
rust-lang:masterfrom
lostiniceland:5717-update-docs

Conversation

@lostiniceland

@lostiniceland lostiniceland commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Updates #5717

Since people tend to copy/paste, the docs should not use the option which will disable curls low-speed-limit. Rather use a value lower than the default of 10

Also reverts removal of default low-speed-time (30s) in case no timeout is configured

Updates rust-lang#5717

Since people tend to copy/paste, the docs should not use the option which will disable curls low-speed-limit. Rather use a value lower than the default of 10
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Thanks!

@bors

bors commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

📌 Commit f88adb0 has been approved by alexcrichton

In case no timeout is specified a default value is needed.
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

📌 Commit 189f14f has been approved by alexcrichton

@bors

bors commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit 189f14f with merge 57e6b3a...

bors added a commit that referenced this pull request Sep 4, 2018
Do not use a disabled-option in the docs

Updates #5717

Since people tend to copy/paste, the docs should not use the option which will disable curls low-speed-limit. Rather use a value lower than the default of 10

Also reverts removal of default low-speed-time (30s) in case no timeout is configured
@bors

bors commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 57e6b3a to master...

@bors
bors merged commit 189f14f into rust-lang:master Sep 4, 2018
@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants