Skip to content

Don't hardlink rmeta files.#6292

Merged
bors merged 1 commit into
rust-lang:masterfrom
ehuss:no-rmeta-hardlink
Nov 10, 2018
Merged

Don't hardlink rmeta files.#6292
bors merged 1 commit into
rust-lang:masterfrom
ehuss:no-rmeta-hardlink

Conversation

@ehuss

@ehuss ehuss commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

.rmeta files shouldn't be needed in the main directory, and since rustc started outputing rmeta files for binaries, there are name collisions between bins and libs of the same name.

Partial fix for #5524.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

📌 Commit 61f9588 has been approved by alexcrichton

@bors

bors commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit 61f9588 with merge 19eb6d6...

bors added a commit that referenced this pull request Nov 9, 2018
Don't hardlink rmeta files.

`.rmeta` files shouldn't be needed in the main directory, and since rustc started outputing rmeta files for binaries, there are name collisions between bins and libs of the same name.

Partial fix for #5524.
@bors

bors commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@ehuss

ehuss commented Nov 9, 2018

Copy link
Copy Markdown
Contributor Author

@bors retry

@bors

bors commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit 61f9588 with merge f0950da...

bors added a commit that referenced this pull request Nov 9, 2018
Don't hardlink rmeta files.

`.rmeta` files shouldn't be needed in the main directory, and since rustc started outputing rmeta files for binaries, there are name collisions between bins and libs of the same name.

Partial fix for #5524.
@bors

bors commented Nov 10, 2018

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f0950da to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants