tests: Add a test for rust-lang/rust#57462 and go-to-definition without racer in general.

[emilio]

No description provided.

[Xanewok]

And without the racer fallback we're not able to go to the definition of either Foo or Foo::new.

Are you sure? I tried with "rust.goto_def_racer_fallback": false and in this case the go-to-def worked only on new.

Could you try initializing with

"rootPath": root_path,
"capabilities": {},
"initializationOptions": {
    "settings": {
        "rust": {
            "goto_def_racer_fallback": false
        }
    }
}

and see if we can go-to-def on new but not on Foo?

[emilio]

Will try, thanks for the hint!

[emilio]

Ok, what was going on is that I wasn't waiting for the initialize response, so that was biting me and I was missing responses.

I added a more complete test where I query all the points in the program with racer disabled, but I can keep it simple and just test that I find Foo in Foo::new instead, just lmk.

[emilio]

(The reason I did that is because we have a couple more bugs reported against searchfox.org which may share the same root cause, but if they don't I may need to go and fix them and extend this test :P).

[emilio]

Ok, this should be good to go now. Test fails without my patch, passes with it. Also sent an improvement to existing tests in #1232.

[Xanewok]

I added a more complete test where I query all the points in the program

That seems total but I like that, thanks!

As I understand it, this should fail now and we should retrigger it when rust-lang/rust#57474 lands upstream?

[emilio]

Yes, that's right.

[Xanewok]

Sorry for the merge conflict; could you rebase, please? Also the upstream change got merged, so I think this should be good to go.

[emilio]

Sure, should be done :)

[Xanewok]

Windows tests fail:
Got

"file:///C:/Users/travis/build/rust-lang/rls/target/rlsit/t13/simple_workspace/src/main.rs"

Expected

file://C:\\Users\\travis\\build\\rust-lang\\rls\\target\\rlsit\\t13\\simple_workspace/src/main.rs

I think something like let uri = Url::from_file_path(p.root().join("src/main.rs")).unwrap(); should make it work cross-platform

[emilio]

Tweaked it to avoid having to compare the URL instead.

[Xanewok]

@bors r+

[bors]

📌 Commit e9e643b has been approved by Xanewok

[bors]

⌛ Testing commit e9e643b with merge 17dae09...

[bors]

☀️ Test successful - checks-travis
Approved by: Xanewok
Pushing 17dae09 to master...

[Xanewok]

@emilio Thank you again for the test =)

[emilio]

NP! :)