x.py setup dist says it uses src/bootstrap/defaults/config.dist.toml, which does not exist

[pnkfelix]

Just like the title says, I did x.py setup and selected "dist", which claims it inherits its settings from a file that does not actually exist.

[pnkfelix]

Oh and even better, when you then do x.py dist in the resulting directory that has that config.toml generated via x.py setup dist, you get this error:

% ../x.py  dist
Traceback (most recent call last):
  File "/media/pnkfelix/Rust/rust.git/objdir-beta/../x.py", line 50, in <module>
    bootstrap.main()
  File "/media/pnkfelix/Rust/rust.git/src/bootstrap/bootstrap.py", line 1094, in main
    bootstrap(args)
  File "/media/pnkfelix/Rust/rust.git/src/bootstrap/bootstrap.py", line 1030, in bootstrap
    with open(include_path) as included_toml:
FileNotFoundError: [Errno 2] No such file or directory: '/media/pnkfelix/Rust/rust.git/src/bootstrap/defaults/config.dist.toml'

and it seems like all subseqent calls to x.py, including one to x.py setup itself, will cause that same failure (which is not surprising).

[pnkfelix]

(Should we have a check at the time when we generate the config.toml ensuring that the referenced settings file exists? And if it doesn't ... abort the attempt to generate config.toml in the first place? This seems like a somewhat unfortunate scneario to get into. The main other options I can imagine are 1. to issue an error when the file denoted by profile = "xxx" doesn't exist, at the time when we are invoking x.pywith an incoherentconfig.toml, or 2. to "just" issue a warning when the file denoted by profile = "xxx"doesn't exist, but otherwise continue with the givenconfig.toml` as it stands.)

[clubby789]

Might be related to the issues raisesd in #112166 (comment)

[albertlarsan68]

Yep, it is a direct consequence. I think we should revert this PR, it seems to be causing more harm than good.