Skip to content

Test drop_tracking_mir before querying generator.#107443

Merged
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:generator-less-query
Jan 31, 2023
Merged

Test drop_tracking_mir before querying generator.#107443
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:generator-less-query

Conversation

@cjgillot

Copy link
Copy Markdown
Contributor

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 29, 2023
@cjgillot
cjgillot force-pushed the generator-less-query branch from 56298e4 to 1d3f5b4 Compare January 29, 2023 13:50
@cjgillot

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2023
@bors

bors commented Jan 29, 2023

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 1d3f5b4 with merge dedcd09ba9ab62b2f519bbb146ecd9133b70f60f...

@bors

bors commented Jan 29, 2023

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: dedcd09ba9ab62b2f519bbb146ecd9133b70f60f (dedcd09ba9ab62b2f519bbb146ecd9133b70f60f)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (dedcd09ba9ab62b2f519bbb146ecd9133b70f60f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.7%, -0.2%] 13
Improvements ✅
(secondary)
-0.7% [-1.1%, -0.4%] 8
All ❌✅ (primary) -0.6% [-0.7%, -0.2%] 13

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.7% [1.7%, 1.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.5% [-4.5%, -4.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.0%] 2
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2023
@cjgillot
cjgillot marked this pull request as ready for review January 29, 2023 19:27
@rustbot

rustbot commented Jan 29, 2023

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot

Copy link
Copy Markdown
Contributor Author

r? compiler

@compiler-errors

Copy link
Copy Markdown
Contributor

r? @compiler-errors @bors r+

@bors

bors commented Jan 29, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 1d3f5b4 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned TaKO8Ki Jan 29, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023
@bors

bors commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1d3f5b4 with merge 9c0ee1a97e8d08204a9b9244b2ff87c792ed8537...

@bors

bors commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2023
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors retry spurious time="2023-01-31T00:02:12Z" level=error msg="error waiting for container: unexpected EOF"

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 31, 2023
@bors

bors commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1d3f5b4 with merge dc3e59c...

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
      |   ^~~~~~~~~~~~~~~
/checkout/src/llvm-project/llvm/include/llvm/IR/ModuleSummaryIndex.h:710:3: note: parameter passing for argument of type ‘llvm::FunctionSummary::FFlags’ changed in GCC 9.1
[926/3023] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/PruneEH.cpp.o
[927/3023] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/PassManagerBuilder.cpp.o
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

@bors

bors commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing dc3e59c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 31, 2023
@bors
bors merged commit dc3e59c into rust-lang:master Jan 31, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 31, 2023
@cjgillot
cjgillot deleted the generator-less-query branch January 31, 2023 07:40
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (dc3e59c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.6%, -0.2%] 14
Improvements ✅
(secondary)
-0.7% [-1.0%, -0.4%] 8
All ❌✅ (primary) -0.5% [-0.6%, -0.2%] 14

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 2
Regressions ❌
(secondary)
3.2% [0.9%, 7.1%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.0% [3.0%, 3.0%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.8% [-1.8%, -1.8%] 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants