Skip to content

fixed typo#113539

Merged
bors merged 1 commit into
rust-lang:masterfrom
agnarrarendelle:master
Jul 17, 2023
Merged

fixed typo#113539
bors merged 1 commit into
rust-lang:masterfrom
agnarrarendelle:master

Conversation

@agnarrarendelle

@agnarrarendelle agnarrarendelle commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Hi, I have fixed a few typos in commands. Please review my pr.

@rustbot

rustbot commented Jul 10, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 10, 2023
@rustbot

rustbot commented Jul 10, 2023

Copy link
Copy Markdown
Collaborator

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

WaffleLapkin
WaffleLapkin requested changes Jul 10, 2023
View reviewed changes
Comment thread compiler/rustc_middle/src/ty/consts/valtree.rs Outdated
Comment on lines 26 to 27

@WaffleLapkin WaffleLapkin Jul 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a typo, this is commented out code.

@agnarrarendelle agnarrarendelle Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, fixed it now

@WaffleLapkin WaffleLapkin Jul 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not fixed, // dont use SliceOrStr for now is also part of the comment and not documentation

@agnarrarendelle agnarrarendelle Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have undone everything besides changing // dont to // don't. Please have a look.

@WaffleLapkin

WaffleLapkin commented Jul 10, 2023

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
WaffleLapkin
WaffleLapkin approved these changes Jul 10, 2023
View reviewed changes

@WaffleLapkin WaffleLapkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Please squash commits together.

@agnarrarendelle

agnarrarendelle commented Jul 11, 2023

Copy link
Copy Markdown
Contributor Author

I have combined the commits together now

@workingjubilee

workingjubilee commented Jul 16, 2023

Copy link
Copy Markdown
Member

Thanks!
@bors r+ rollup

@bors

bors commented Jul 16, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit dcfcc77 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2023
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 16, 2023
@workingjubilee
Rollup merge of rust-lang#113539 - agnarrarendelle:master, r=workingj…
7002e1a 
…ubilee

fixed typo

Hi, I have fixed a few typos in commands. Please review my pr.
@workingjubilee workingjubilee mentioned this pull request Jul 16, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2023
@bors
Auto merge of rust-lang#113769 - matthiaskrgr:rollup-p6i1rco, r=matth…
f1eab64 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#113042 (Add Platform Support documentation for MIPS Release 6 targets)
 - rust-lang#113539 (fixed typo)
 - rust-lang#113614 (platform-support.md: It's now verified that NetBSD/riscv64 can self-h…)
 - rust-lang#113750 (Add missing italicization to `sort_unstable_by_key` complexity )
 - rust-lang#113755 (Normalize lazy type aliases when probing for ADTs)
 - rust-lang#113756 (fix wrong link)
 - rust-lang#113762 (Fix typo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 2b4c194 into rust-lang:master Jul 17, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

5 participants

@agnarrarendelle @rustbot @WaffleLapkin @workingjubilee @bors