Add `#[rustc_test_entrypoint_marker]`#158854

jdonszelmann · 2026-07-06T10:56:03Z

Some context: a bunch of tooling around rustc likes to find entry points. This is easy for main, it's a lang item. But tests aren't as easy. There is already a similar marker for the data structure associated with tests, but if you want to do for example dynamic analysis, you want just the defid of the function you can call to start the tests. This is that marker. There's a test using a rustc driver that the attr indeed shows up and marks the test functions.

@Nadrieril and @N1ark asked for this kind of behavior. I talked to @aDotInTheVoid about whether we should do things like this where we cannot really guarantee the stability or even use it inside rustc. The thing is, we don't provide staboility guarantees, it's just a useful little thing to have for as long as its there and it doesn't bother anyone either. It's up to tool authors to deal with breakage we may introduce.

rustbot · 2026-07-06T10:56:08Z

Some changes occurred in compiler/rustc_hir/src/attrs

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @JonathanBrouwer

rustbot · 2026-07-06T10:56:10Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

JonathanBrouwer · 2026-07-07T20:37:16Z

(this might take me a few days to get to, should have time to take a look on friday)

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-07-10T09:29:53Z

📌 Commit 0133252 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…nathanBrouwer Add `#[rustc_test_entrypoint_marker]` r? @JonathanBrouwer cc: @Nadrieril @N1ark @aDotInTheVoid Some context: a bunch of tooling around rustc likes to find entry points. This is easy for `main`, it's a lang item. But tests aren't as easy. There is already a similar marker for the data structure associated with tests, but if you want to do for example dynamic analysis, you want just the defid of the function you can call to start the tests. This is that marker. There's a test using a rustc driver that the attr indeed shows up and marks the test functions. @Nadrieril and @N1ark asked for this kind of behavior. I talked to @aDotInTheVoid about whether we should do things like this where we cannot really guarantee the stability or even use it inside rustc. The thing is, we don't provide staboility guarantees, it's just a useful little thing to have for as long as its there and it doesn't bother anyone either. It's up to tool authors to deal with breakage we may introduce.

…uwer Rollup of 7 pull requests Successful merges: - #157690 (codegen_ssa: pack small const aggregates into immediate stores) - #159005 (Use `as_lang_item` instead of repeatedly matching) - #156735 (Move NativeLib::filename to the rmeta-link archive member) - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158965 (Add codegen test for Result is_ok unwrap) - #159050 (assert only opaques with sub unified hidden infer are non-rigid)

JonathanBrouwer · 2026-07-10T12:35:29Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #159068 (comment)

rust-bors · 2026-07-10T12:35:38Z

This pull request was unapproved.

This PR was contained in a rollup (#159068), which was unapproved.

View changes since this unapproval

rustbot · 2026-07-13T10:02:46Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-07-13T10:03:34Z

@bors try jobs=x86_64-gnu-llvm-21-3

Add `#[rustc_test_entrypoint_marker]` try-job: x86_64-gnu-llvm-21-3

rust-bors · 2026-07-13T10:37:37Z

💔 Test for 97c51aa failed: CI. Failed job:

try - x86_64-gnu-llvm-21-3 (web logs, enhanced plaintext logs)

jdonszelmann · 2026-07-13T10:46:40Z

This should fix it

jdonszelmann · 2026-07-13T10:46:44Z

@bors try jobs=x86_64-gnu-llvm-21-3

Add `#[rustc_test_entrypoint_marker]` try-job: x86_64-gnu-llvm-21-3

jdonszelmann · 2026-07-13T11:28:05Z

yeah, it got past the problem test. @bors r=jonathanbrouwer

rust-bors · 2026-07-13T11:28:08Z

📌 Commit 843639b has been approved by jonathanbrouwer

It is now in the queue for this repository.

rust-bors · 2026-07-13T12:48:56Z

☀️ Try build successful (CI)
Build commit: 3e62383 (3e62383d788476b2d2a63e6d43718f279c2c1fd6)
Base parent: 5503df8 (5503df87342a73d0c29126a7e08dc9c1255c46ad)

@JonathanBrouwer

…nathanbrouwer Add `#[rustc_test_entrypoint_marker]` r? @JonathanBrouwer cc: @Nadrieril @N1ark @aDotInTheVoid Some context: a bunch of tooling around rustc likes to find entry points. This is easy for `main`, it's a lang item. But tests aren't as easy. There is already a similar marker for the data structure associated with tests, but if you want to do for example dynamic analysis, you want just the defid of the function you can call to start the tests. This is that marker. There's a test using a rustc driver that the attr indeed shows up and marks the test functions. @Nadrieril and @N1ark asked for this kind of behavior. I talked to @aDotInTheVoid about whether we should do things like this where we cannot really guarantee the stability or even use it inside rustc. The thing is, we don't provide staboility guarantees, it's just a useful little thing to have for as long as its there and it doesn't bother anyone either. It's up to tool authors to deal with breakage we may introduce.

…uwer Rollup of 13 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #156712 (Pointer authentication config and user facing options) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

@JonathanBrouwer

…nathanbrouwer Add `#[rustc_test_entrypoint_marker]` r? @JonathanBrouwer cc: @Nadrieril @N1ark @aDotInTheVoid Some context: a bunch of tooling around rustc likes to find entry points. This is easy for `main`, it's a lang item. But tests aren't as easy. There is already a similar marker for the data structure associated with tests, but if you want to do for example dynamic analysis, you want just the defid of the function you can call to start the tests. This is that marker. There's a test using a rustc driver that the attr indeed shows up and marks the test functions. @Nadrieril and @N1ark asked for this kind of behavior. I talked to @aDotInTheVoid about whether we should do things like this where we cannot really guarantee the stability or even use it inside rustc. The thing is, we don't provide staboility guarantees, it's just a useful little thing to have for as long as its there and it doesn't bother anyone either. It's up to tool authors to deal with breakage we may introduce.

…uwer Rollup of 14 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

@JonathanBrouwer

…nathanbrouwer Add `#[rustc_test_entrypoint_marker]` r? @JonathanBrouwer cc: @Nadrieril @N1ark @aDotInTheVoid Some context: a bunch of tooling around rustc likes to find entry points. This is easy for `main`, it's a lang item. But tests aren't as easy. There is already a similar marker for the data structure associated with tests, but if you want to do for example dynamic analysis, you want just the defid of the function you can call to start the tests. This is that marker. There's a test using a rustc driver that the attr indeed shows up and marks the test functions. @Nadrieril and @N1ark asked for this kind of behavior. I talked to @aDotInTheVoid about whether we should do things like this where we cannot really guarantee the stability or even use it inside rustc. The thing is, we don't provide staboility guarantees, it's just a useful little thing to have for as long as its there and it doesn't bother anyone either. It's up to tool authors to deal with breakage we may introduce.

…uwer Rollup of 15 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #156047 (Fix trait method resolution on an adjusted never type) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158804 (Clarify `as_uninit_mut` may point to uninitialized memory) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

…uwer Rollup of 13 pull requests Successful merges: - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158804 (Clarify `as_uninit_mut` may point to uninitialized memory) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

@JonathanBrouwer

Rollup merge of #158854 - jdonszelmann:test-entrypoint, r=jonathanbrouwer Add `#[rustc_test_entrypoint_marker]` r? @JonathanBrouwer cc: @Nadrieril @N1ark @aDotInTheVoid Some context: a bunch of tooling around rustc likes to find entry points. This is easy for `main`, it's a lang item. But tests aren't as easy. There is already a similar marker for the data structure associated with tests, but if you want to do for example dynamic analysis, you want just the defid of the function you can call to start the tests. This is that marker. There's a test using a rustc driver that the attr indeed shows up and marks the test functions. @Nadrieril and @N1ark asked for this kind of behavior. I talked to @aDotInTheVoid about whether we should do things like this where we cannot really guarantee the stability or even use it inside rustc. The thing is, we don't provide staboility guarantees, it's just a useful little thing to have for as long as its there and it doesn't bother anyone either. It's up to tool authors to deal with breakage we may introduce.

…nszelmann Construct `tokens` for attrs made by `mk_attr_word` and other variants Fixes rust-lang#159261 `tokens` won't be constructed for generated built-in attrs before, so that after rust-lang#158854, `#[rustc_test_entrypoint_marker]` without `tokens` would be added when expanding `#[test]`. Then later expansions would cause the ICE when they wanna get the attr's `tokens`. This PR makes `tokens` constructed for such attrs, although this specific ICE only need editing `mk_attr_word`, but I think it would be good to also edit `mk_attr_nested_word` and `mk_attr_name_value_str`.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2026

rustbot assigned JonathanBrouwer Jul 6, 2026

jdonszelmann force-pushed the test-entrypoint branch from 26da690 to 1e795a9 Compare July 6, 2026 11:01

This comment has been minimized.

Sign in to view

JonathanBrouwer approved these changes Jul 10, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2026

JonathanBrouwer mentioned this pull request Jul 10, 2026

Rollup of 7 pull requests #159068

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 10, 2026

Nadrieril reviewed Jul 10, 2026

View reviewed changes

Comment thread tests/ui-fulldeps/test_entrypoint_attrs.rs

introduce a test entrypoint marker for tools

e0f9f8c

jdonszelmann force-pushed the test-entrypoint branch from 0133252 to b80ee35 Compare July 13, 2026 10:02

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 13, 2026

Auto merge of #158854 - jdonszelmann:test-entrypoint, r=<try>

97c51aa

Add `#[rustc_test_entrypoint_marker]` try-job: x86_64-gnu-llvm-21-3

This comment has been minimized.

Sign in to view

add test

d873077

jdonszelmann force-pushed the test-entrypoint branch from b80ee35 to 843639b Compare July 13, 2026 10:46

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 13, 2026

Auto merge of #158854 - jdonszelmann:test-entrypoint, r=<try>

3e62383

Add `#[rustc_test_entrypoint_marker]` try-job: x86_64-gnu-llvm-21-3

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2026

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 13 pull requests #159231

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 14 pull requests #159236

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 15 pull requests #159240

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 13 pull requests #159246

Merged

rust-bors Bot merged commit aa45526 into rust-lang:main Jul 13, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 13, 2026

dtolnay mentioned this pull request Jul 14, 2026

[ICE]: "attribute is missing tokens" on #[test] #[procmacro] #159261

Open

mu001999 mentioned this pull request Jul 14, 2026

Construct tokens for attrs made by mk_attr_word and other variants #159277

Open

Xuanwo mentioned this pull request Jul 14, 2026

bug: Rust linux-build ICEs on nightly-2026-07-14 lance-format/lance#7786

Open

Uh oh!

Uh oh!

Conversation

jdonszelmann commented Jul 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jul 7, 2026

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jul 10, 2026

Uh oh!

JonathanBrouwer commented Jul 10, 2026

Uh oh!

rust-bors Bot commented Jul 10, 2026

Uh oh!

Uh oh!

rustbot commented Jul 13, 2026

Uh oh!

jdonszelmann commented Jul 13, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 13, 2026

Uh oh!

This comment has been minimized.

jdonszelmann commented Jul 13, 2026

Uh oh!

jdonszelmann commented Jul 13, 2026

Uh oh!

This comment has been minimized.

jdonszelmann commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jdonszelmann commented Jul 6, 2026 •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading