Skip to content

tests: catch up with LLVM returning f128 on the stack#158889

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-23-win-x64-f128
Jul 8, 2026
Merged

tests: catch up with LLVM returning f128 on the stack#158889
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-23-win-x64-f128

Conversation

@durin42

@durin42 durin42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

In LLVM 22 the x64 MSVC ABI wasn't matched and f128 was being directly returned in %xmm0, but now it correctly returns the value via a pointer.

@durin42
tests: catch up with LLVM returning f128 on the stack
f05ac1d 
In LLVM 22 the x64 MSVC ABI wasn't matched and f128 was being directly
returned in %xmm0, but now it correctly returns the value via a pointer.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2026
@rustbot

rustbot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@durin42

durin42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot label: +llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Jul 7, 2026
@nikic

nikic commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

cc @folkertdev, not sure how this relates to #158778

@folkertdev

folkertdev commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Well, we should merge this. That draft PR was so that I could locally test rust-lang/compiler-builtins tests, and contains some changes we'll want to make when we switch to LLVM 23.

We should adjust how f128 is passed on the rustc end, but our callconv code doesn't know the LLVM version I think so that'll be interesting. Maybe we can just unconditionally switch to the new approach given that f128 is unstable anyway and linking it with clang-22 on windows is probably extremely rare.

edit: for future reference, the behavior here was changed in llvm/llvm-project#204887.

folkertdev
folkertdev approved these changes Jul 7, 2026
View reviewed changes

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if you want to merge this quickly. We can make further changes in a follow-up

View changes since this review

@nikic

nikic commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@bors r=folkertdev rollup

@rust-bors

rust-bors Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f05ac1d has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158889 - durin42:llvm-23-win-x64-f128, r=fo…
e6bfe00 
…lkertdev

tests: catch up with LLVM returning f128 on the stack

In LLVM 22 the x64 MSVC ABI wasn't matched and f128 was being directly returned in %xmm0, but now it correctly returns the value via a pointer.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158889 - durin42:llvm-23-win-x64-f128, r=fo…
f090626 
…lkertdev

tests: catch up with LLVM returning f128 on the stack

In LLVM 22 the x64 MSVC ABI wasn't matched and f128 was being directly returned in %xmm0, but now it correctly returns the value via a pointer.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158911 - JonathanBrouwer:rollup-RXBIXmN, r=JonathanBro…
12fe3a4 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - #158617 (allow mGCA const arguments to fall back to anon consts)
 - #158621 (disallow `extern "custom"` on wasm and spirv targets)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158791 (Avoid unused braces lint for macro generated arguments)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158889 (tests: catch up with LLVM returning f128 on the stack)
 - #158905 (delegation: add constraints to new generic args)
@tgross35 tgross35 mentioned this pull request Jul 7, 2026
Draft
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@tgross35
DO NOT MERGE merge #158889
18ae03c
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158889 - durin42:llvm-23-win-x64-f128, r=fo…
65d0114 
…lkertdev

tests: catch up with LLVM returning f128 on the stack

In LLVM 22 the x64 MSVC ABI wasn't matched and f128 was being directly returned in %xmm0, but now it correctly returns the value via a pointer.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158923 - JonathanBrouwer:rollup-HAAKMUz, r=JonathanBro…
e38cd22 
…uwer

Rollup of 18 pull requests

Successful merges:

 - #157385 (Enable Enzyme on x86_64-apple)
 - #157561 (rustdoc: do not include extra stuff in span)
 - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - #158617 (allow mGCA const arguments to fall back to anon consts)
 - #158621 (disallow `extern "custom"` on wasm and spirv targets)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158697 (Fixes for QNX SDP 8)
 - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
 - #157801 (Rewrite safety requirements for `Allocator` impls)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
 - #158791 (Avoid unused braces lint for macro generated arguments)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158841 (Avoid final override ICE for RPITIT associated types)
 - #158889 (tests: catch up with LLVM returning f128 on the stack)
 - #158905 (delegation: add constraints to new generic args)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158924 - JonathanBrouwer:rollup-rCVjim4, r=JonathanBro…
76fcc1c 
…uwer

Rollup of 19 pull requests

Successful merges:

 - #156016 (view-types: store view types in the AST)
 - #157385 (Enable Enzyme on x86_64-apple)
 - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - #158621 (disallow `extern "custom"` on wasm and spirv targets)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158697 (Fixes for QNX SDP 8)
 - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
 - #157801 (Rewrite safety requirements for `Allocator` impls)
 - #158085 (rustdoc: Fix sidebar heading order)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
 - #158791 (Avoid unused braces lint for macro generated arguments)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158841 (Avoid final override ICE for RPITIT associated types)
 - #158889 (tests: catch up with LLVM returning f128 on the stack)
 - #158905 (delegation: add constraints to new generic args)
 - #158922 (tests: clean up over-constraint on LLVM feature count)

Failed merges:

 - #158617 (allow mGCA const arguments to fall back to anon consts)
@rust-bors rust-bors Bot merged commit 3773982 into rust-lang:main Jul 8, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 8, 2026
rust-timer added a commit that referenced this pull request Jul 8, 2026
@rust-timer
Unrolled build for #158889
74aeca8 
Rollup merge of #158889 - durin42:llvm-23-win-x64-f128, r=folkertdev

tests: catch up with LLVM returning f128 on the stack

In LLVM 22 the x64 MSVC ABI wasn't matched and f128 was being directly returned in %xmm0, but now it correctly returns the value via a pointer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees

@davidtwco davidtwco

Labels

llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

5 participants

@durin42 @rustbot @nikic @folkertdev @davidtwco