Deprecate String::from_str in favor of String::from#26077
Conversation
With the latter is provided by the `From` conversion trait, the former is now completely redundant. Their code is identical.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
👍 We should look over the other implementors of |
|
⌛ Testing commit 2ff4243 with merge bcf7147... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
|
|
I am pro removing this, but we may want to wait a few cycles, as this method used to be very popular. Then again, the probability that old code works is so low anyway.... |
With the latter is provided by the `From` conversion trait, the former is now completely redundant. Their code is identical. Let’s deprecate now and plan to remove in the next cycle. (It’s `#[unstable]`.) r? @alexcrichton CC @nagisa
6 participants
With the latter is provided by the
Fromconversion trait, the former is now completely redundant. Their code is identical. Let’s deprecate now and plan to remove in the next cycle. (It’s#[unstable].)r? @alexcrichton
CC @nagisa