Skip to content

Avoid calling fn_sig on closures#69154

Merged
bors merged 1 commit into
rust-lang:masterfrom
JohnTitor:fix-macro-ices
Feb 15, 2020
Merged

Avoid calling fn_sig on closures#69154
bors merged 1 commit into
rust-lang:masterfrom
JohnTitor:fix-macro-ices

Conversation

@JohnTitor

@JohnTitor JohnTitor commented Feb 14, 2020

Copy link
Copy Markdown
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2020
petrochenkov
petrochenkov reviewed Feb 14, 2020
View reviewed changes
Comment thread src/librustc_typeck/collect.rs Outdated
Comment thread src/librustc_typeck/collect.rs Outdated
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2020
@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2020
petrochenkov
petrochenkov reviewed Feb 14, 2020
View reviewed changes
Comment thread src/test/compile-fail/issue-68060.rs Outdated
@petrochenkov

petrochenkov commented Feb 14, 2020

Copy link
Copy Markdown
Contributor

r=me after moving the test to ui, if that's possible.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2020
@petrochenkov

petrochenkov commented Feb 14, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 14, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 47aa2b5 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#69154 - JohnTitor:fix-macro-ices, r=petroch…
c115ad9 
…enkov

Avoid calling `fn_sig` on closures

Fixes rust-lang#68060

r? @petrochenkov
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 15, 2020
Merged
bors added a commit that referenced this pull request Feb 15, 2020
@bors
Auto merge of #69182 - Dylan-DPC:rollup-ifsa9fx, r=Dylan-DPC
dbef353 
Rollup of 6 pull requests

Successful merges:

 - #64069 (Added From<Vec<NonZeroU8>> for CString)
 - #66721 (implement LowerExp and UpperExp for integers)
 - #69106 (Fix std::fs::copy on WASI target)
 - #69154 (Avoid calling `fn_sig` on closures)
 - #69166 (Check `has_typeck_tables` before calling `typeck_tables_of`)
 - #69180 (Suggest a comma if a struct initializer field fails to parse)

Failed merges:

r? @ghost
@bors
bors merged commit 47aa2b5 into rust-lang:master Feb 15, 2020
@JohnTitor
JohnTitor deleted the fix-macro-ices branch February 15, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Another macro ICE

4 participants

@JohnTitor @petrochenkov @bors @rust-highfive