Skip to content

Update lib.rs#54

Merged
bors[bot] merged 1 commit into
rust-num:masterfrom
hkBst:patch-1
Apr 24, 2023
Merged

Update lib.rs#54
bors[bot] merged 1 commit into
rust-num:masterfrom
hkBst:patch-1

Conversation

@hkBst

@hkBst hkBst commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

First test that qr/dm is correct, then that both methods' results are equal to the correct answer. This saves one redundant check.

small simplification
@cuviper

cuviper commented Mar 29, 2023

Copy link
Copy Markdown
Member

OK - it doesn't really matter to have redundancies in test code, but the change looks fine.

bors r+

meta: please use a more descriptive commit title in any future pull requests.

bors Bot added a commit that referenced this pull request Mar 29, 2023
54: Update lib.rs r=cuviper a=hkBst

First test that qr/dm is correct, then that both methods' results are equal to the correct answer. This saves one redundant check.

Co-authored-by: Marijn Schouten <hkBst@users.noreply.github.com>
@bors

bors Bot commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Build failed:

@cuviper

cuviper commented Mar 29, 2023

Copy link
Copy Markdown
Member

Hmm, I think the nightly compiler is misbehaving there -- I'll file an upstream bug.

@cuviper

cuviper commented Apr 24, 2023

Copy link
Copy Markdown
Member

bors retry

@bors

bors Bot commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
bors Bot merged commit 80c2b22 into rust-num:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants