chore(ci): add fix-markers for recent merges (#559, #561, #588, #593, #590-CI)#606
Merged
Merged
Conversation
…590-CI) Six new entries in scripts/fix-markers.json so the regression guard (.github/workflows/fix-regression-guard.yml + scripts/check_fix_markers.py) catches a future revert of any of these fixes: - RuView#559 — ./verify points at archive/v1/ paths - RuView#561 — README app flash offset 0x20000 + ota_data_initial.bin at 0xf000 + canonical provision.py path - RuView#588-SEC020 — provision.py prints (set)/(empty), not '*' * len(pw) (forbids the asterisk-run pattern that leaks password length) - RuView#593 — vital_signs.rs uses phase_circular_variance for wrapped phases - RuView#590-fuzz-stub — esp_stubs.h declares wifi_ps_type_t / WIFI_PS_NONE / esp_wifi_set_ps (keeps Fuzz Testing job green) - RuView#590-swarm-test — qemu_swarm.py passes --force-partial to provision.py (keeps Swarm Test ADR-062 job green) Verified: `python scripts/check_fix_markers.py` reports All 17 fix markers present. Co-Authored-By: claude-flow <ruv@ruv.net>
Closed
4 tasks
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 6 new entries to `scripts/fix-markers.json` so the regression guard catches a future revert of any fix that just landed via PRs #590, #584, #595, #604, #602:
Each marker carries a `rationale` linking to the original incident, so a future contributor who hits a guard failure understands why the assertion is there.
Verification
```
$ python scripts/check_fix_markers.py
Fix-marker regression guard - 17 marker(s)
…
All 17 fix markers present.
```
CI's `Fix-Marker Regression Guard` workflow will run the same check on every PR.
Why this matters
Three of these fixes shipped on PR #590 (#559, #561, #588) and one on PR #595 (#593). The other two cover the CI infrastructure fixes that brought the Fuzz Testing and Swarm Test (ADR-062) jobs back to green after ~5 weeks red on `main`. Without these markers a future cleanup-PR could trivially revert any of them in a refactor without any signal at review time.
🤖 Generated with claude-flow