Skip to content

Fix mdbook build.#6891

Merged
mergify[bot] merged 1 commit into
sigp:unstablefrom
jimmygchen:fix-md-book
Jan 31, 2025
Merged

Fix mdbook build.#6891
mergify[bot] merged 1 commit into
sigp:unstablefrom
jimmygchen:fix-md-book

Conversation

@jimmygchen

Copy link
Copy Markdown
Member

Issue Addressed

https://github.com/sigp/lighthouse/actions/runs/13063781937/job/36452383133

mdbook ci job above is failing because the latest release now requires a newer version of glibc:

Updated the Linux pre-built binaries which requires a newer version of glibc (2.34). rust-lang/mdBook#2523

https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md

Updating to latest ubuntu to fix this.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Jan 31, 2025

@michaelsproul michaelsproul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. infra-ci and removed ready-for-review The code is ready for review labels Jan 31, 2025
mergify Bot added a commit that referenced this pull request Jan 31, 2025
@mergify

mergify Bot commented Jan 31, 2025

Copy link
Copy Markdown

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@jimmygchen

Copy link
Copy Markdown
Member Author

@mergify requeue

@mergify

mergify Bot commented Jan 31, 2025

Copy link
Copy Markdown

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify Bot added a commit that referenced this pull request Jan 31, 2025
@mergify
mergify Bot merged commit e4183f8 into sigp:unstable Jan 31, 2025
@dknopik dknopik mentioned this pull request Feb 17, 2025
@diegomrsantos

Copy link
Copy Markdown
Contributor

Since mdBook hasn’t reached version 1.0 yet, and breaking changes were introduced in a patch release, it might be worth considering pinning the mdBook version to avoid unexpected issues in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra-ci ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants