Fixes for SQL write with RETURNING#2763
Merged
Merged
Conversation
Use the router-stripped route_path when building request-derived export URLs, so table, row, and query JSON/CSV links do not apply base_url twice. Keep urls.path() behavior unchanged, and add coverage for both /prefix/ exports and a /data/ base_url with a data database. Closes #2759
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 67 67
Lines 10223 10295 +72
=====================================
- Misses 10223 10295 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We select 11 when we return 10 just to detect if the results were truncated. We were returning rowcount: 11 in this case when it should have been -1.
Owner
Author
|
Tests are failing because SQLite 3.25.0 (the earliest version Datasette supports) does not support RETURNING. |
simonw
added a commit
that referenced
this pull request
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
📚 Documentation preview 📚: https://datasette--2763.org.readthedocs.build/en/2763/